Skip to content

fix(release): decouple Play promotion from GitHub release #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuilhermeAlbert merged 1 commit into from
Sep 16, 2026
Merged

fix(release): decouple Play promotion from GitHub release #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/android-production-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ jobs:
run: node scripts/verify-android-aab.mjs "${{ steps.aab.outputs.path }}"

- name: Create draft GitHub Release
continue-on-error: true
id: draft
env:
AAB_PATH: ${{ steps.aab.outputs.path }}
Expand Down Expand Up @@ -223,6 +224,7 @@ jobs:
run: bundle exec fastlane android production "version_code:${{ inputs.version_code }}" "release_status:${{ inputs.release_status }}"

- name: Publish GitHub Release
if: ${{ steps.draft.outcome == 'success' }}
env:
GH_TOKEN: ${{ github.token }}
run: |
Expand Down
9 changes: 9 additions & 0 deletions tests/contracts/android-release.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,15 @@ describe("Android release automation", () => {
expect(productionWorkflow).toContain('release_status:${{ inputs.release_status }}');
});

it("does not let GitHub release permissions block Google Play promotion", () => {
expect(productionWorkflow).toMatch(
/- name: Create draft GitHub Release\n\s+continue-on-error: true/,
);
expect(productionWorkflow).toContain(
"if: ${{ steps.draft.outcome == 'success' }}",
);
});

it("verifies the exact signed bundle before archive, upload, and promotion", () => {
expect(verifier).toContain("AAB_EXPECTED_CERT_SHA256");
expect(verifier).toContain("ANDROID_VERSION_CODE");
Expand Down