Better document code reflection's use of LazyConstant

[liach]

There is this @ParticipatesInPreview marker, which is confusing because it really only allows participation in the use of preview APIs for implementation without allowing the use of preview language features. We should indicate which preview API is being used to simplify maintenance.

---

• I confirm that I make this contribution in accordance with the OpenJDK Interim AI Policy.

---

Progress

• Change must not contain extraneous whitespace

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/babylon.git pull/1099/head:pull/1099
$ git checkout pull/1099

Update a local copy of the PR:
$ git checkout pull/1099
$ git pull https://git.openjdk.org/babylon.git pull/1099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1099

View PR using the GUI difftool:
$ git pr show -t 1099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/babylon/pull/1099.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into code-reflection will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

Better document code reflection's use of LazyConstant

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the code-reflection branch:

• 39496ab: Remove rogue character
• e02dc39: Several boolean-returning code paths in BodyScanner lack target type
• 4192f1e: Fix conversion for compound assignment
• ... and 1 more: https://git.openjdk.org/babylon/compare/98da9e5d295ba9c8bee3d6410201b69e9f926097...code-reflection

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (e7056141)

[PaulSandoz]

The trouble with the comments spread out over the code base is the likely risk they will become stale, as the use of preview features in the implementation change or preview features themselves change when re-previewing or exiting preview. I for one will not remember :-) but I don't have a good answer to this. In this case it may be better not to say anything specific, or alternatively not require the use of preview features which IMO would be a shame.

[bridgekeeper]

@liach This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!