Skip to content

8388284: [s390] resolve_jobject uses wrong branch condition after tmll - #692

Open
Harshit470250 wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-Harshit470250-c5c366ad-master
Open

8388284: [s390] resolve_jobject uses wrong branch condition after tmll#692
Harshit470250 wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-Harshit470250-c5c366ad-master

Conversation

@Harshit470250

@Harshit470250 Harshit470250 commented Aug 5, 2026

Copy link
Copy Markdown

Hi all,

This pull request contains a backport of commit c5c366ad from the openjdk/jdk repository.

The commit being backported was authored by Harshit Dhiman on 17 Jul 2026 and was reviewed by Amit Kumar and Andrew Haley.

Thanks!



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8388284 needs maintainer approval

Issue

  • JDK-8388284: [s390] resolve_jobject uses wrong branch condition after tmll (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/692/head:pull/692
$ git checkout pull/692

Update a local copy of the PR:
$ git checkout pull/692
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/692/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 692

View PR using the GUI difftool:
$ git pr show -t 692

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/692.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 5, 2026

Copy link
Copy Markdown

👋 Welcome back hdhiman! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

@Harshit470250 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8388284: [s390] resolve_jobject uses wrong branch condition after tmll

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2a26511: 8377992: (zipfs) Align ZipFileSystem END header validation with the ZipFile implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@Harshit470250

Copy link
Copy Markdown
Author

/approval request z_tmll uses incorrect branch jump condition that causes failure. low-none risk for other architectures as this is specific to s390x. tier1 test passes with fastdebug vm.

@openjdk openjdk Bot changed the title Backport c5c366ad0cfe33361b0c30597bc71beb4770db09 8388284: [s390] resolve_jobject uses wrong branch condition after tmll Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ @Harshit470250 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

@Harshit470250
8388284: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 5, 2026
@mlbridge

mlbridge Bot commented Aug 5, 2026

Copy link
Copy Markdown

Webrevs

@openjdk openjdk Bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant