8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel() - #701
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel(). This PR fixes an x86 JVM startup crash by disabling UseAESCTRIntrinsics when UseAES is disabled (e.g. -XX:+UseAESCTRIntrinsics -XX:-UseAES). For parity with Oracle JDK. Low risk — narrowly scoped to x86 AES flag resolution, only disables an unusable intrinsic, and behaves identically for all normal flag combinations. |
Backporting JDK-8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel().
This PR fixes an x86 JVM startup crash by disabling UseAESCTRIntrinsics when UseAES is disabled (e.g. -XX:+UseAESCTRIntrinsics -XX:-UseAES).
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/hotspot/jtreg/compiler/cpuflags/TestUseAESCTRIntrinsicsWithUseAESDisabled.java
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/701/head:pull/701$ git checkout pull/701Update a local copy of the PR:
$ git checkout pull/701$ git pull https://git.openjdk.org/jdk25u-dev.git pull/701/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 701View PR using the GUI difftool:
$ git pr show -t 701Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/701.diff
Using Webrev
Link to Webrev Comment