Skip to content

8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel() - #701

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8374516-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel().

This PR fixes an x86 JVM startup crash by disabling UseAESCTRIntrinsics when UseAES is disabled (e.g. -XX:+UseAESCTRIntrinsics -XX:-UseAES).

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/cpuflags/TestUseAESCTRIntrinsicsWithUseAESDisabled.java

Results:

windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8374516 needs maintainer approval

Issue

  • JDK-8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel() (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/701/head:pull/701
$ git checkout pull/701

Update a local copy of the PR:
$ git checkout pull/701
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/701/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 701

View PR using the GUI difftool:
$ git pr show -t 701

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/701.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review August 5, 2026 16:36
@bridgekeeper

bridgekeeper Bot commented Aug 5, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport a69409b0b7bcb4eb9a66327e1c6c53b3361ea1e9 8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel() Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 5, 2026
@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 5, 2026
@mlbridge

mlbridge Bot commented Aug 5, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8374516: -version asserts with "-XX:+UseAESCTRIntrinsics -XX:-UseAES": "need AES instructions and misaligned SSE support" in generate_counterMode_AESCrypt_Parallel().

This PR fixes an x86 JVM startup crash by disabling UseAESCTRIntrinsics when UseAES is disabled (e.g. -XX:+UseAESCTRIntrinsics -XX:-UseAES).

For parity with Oracle JDK.

Low risk — narrowly scoped to x86 AES flag resolution, only disables an unusable intrinsic, and behaves identically for all normal flag combinations.

@openjdk

openjdk Bot commented Aug 5, 2026

Copy link
Copy Markdown

@rm-gh-8
8374516: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant