Skip to content

8372154: AArch64: Match rule failure with some CompareAndSwap operand shapes - #709

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8372154-aarch64-cas-rules
Open

8372154: AArch64: Match rule failure with some CompareAndSwap operand shapes#709
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8372154-aarch64-cas-rules

Conversation

@shipilev

@shipilev shipilev commented Aug 7, 2026

Copy link
Copy Markdown
Member

Fixes the corner case in AArch64 encoding rules that assert in debug and bail out in release.

Additional testing:

  • Linux AArch64 server fastdebug, all
  • Linux AArch64 server release, 24h jcstress run


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8372154 needs maintainer approval

Issue

  • JDK-8372154: AArch64: Match rule failure with some CompareAndSwap operand shapes (Bug - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/709/head:pull/709
$ git checkout pull/709

Update a local copy of the PR:
$ git checkout pull/709
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/709/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 709

View PR using the GUI difftool:
$ git pr show -t 709

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/709.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 7, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 7, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 88ec4e615a3008408184b7ed92010adc75d63853 8372154: AArch64: Match rule failure with some CompareAndSwap operand shapes Aug 7, 2026
@openjdk

openjdk Bot commented Aug 7, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 7, 2026
@openjdk

openjdk Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 7, 2026
@mlbridge

mlbridge Bot commented Aug 7, 2026

Copy link
Copy Markdown

Webrevs

@shipilev

Copy link
Copy Markdown
Member Author

/approval request Fixes the corner case in AArch64 encoding rules that assert in debug and bail out in release. Bailing out from C2 compilation would cause performance anomalies. Patch applies cleanly. There are no follow-ups after 8 months in mainline, except the rewrite to use M4 stencils later. Risk is medium-low: touches C2 match rules, but in simple manner, tests pass, no bugtail.

@openjdk

openjdk Bot commented Aug 11, 2026

Copy link
Copy Markdown

@shipilev
8372154: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant