Skip to content

8389846: GenShen: ShenandoahScanRemembered::process_clusters may miss dirty cards when use write table - #716

Open
earthling-amzn wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-earthling-amzn-91394cbf-master
Open

8389846: GenShen: ShenandoahScanRemembered::process_clusters may miss dirty cards when use write table#716
earthling-amzn wants to merge 1 commit into
openjdk:masterfrom
openjdk-bots:backport-earthling-amzn-91394cbf-master

Conversation

@earthling-amzn

@earthling-amzn earthling-amzn commented Aug 10, 2026

Copy link
Copy Markdown

Clean backport. Fixes heap heap corruption bug in Shenandoah's generational mode.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8389846 needs maintainer approval

Issue

  • JDK-8389846: GenShen: ShenandoahScanRemembered::process_clusters may miss dirty cards when use write table (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/716/head:pull/716
$ git checkout pull/716

Update a local copy of the PR:
$ git checkout pull/716
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/716/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 716

View PR using the GUI difftool:
$ git pr show -t 716

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/716.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 10, 2026

Copy link
Copy Markdown

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 10, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 91394cbfd9446a3efb6d64f321b7a8f088d74241 8389846: GenShen: ShenandoahScanRemembered::process_clusters may miss dirty cards when use write table Aug 10, 2026
@openjdk

openjdk Bot commented Aug 10, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 10, 2026
@openjdk

openjdk Bot commented Aug 10, 2026

Copy link
Copy Markdown

⚠️ @earthling-amzn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 10, 2026
@mlbridge

mlbridge Bot commented Aug 10, 2026

Copy link
Copy Markdown

Webrevs

@earthling-amzn

Copy link
Copy Markdown
Author

/approval request This change fixes a rare condition in which two GC threads both expect the other to complete an object scan, where in actuality, neither worker performs the scan. This may result in a stale reference pointing into recycled memory, likely causing a crash.

@openjdk

openjdk Bot commented Aug 10, 2026

Copy link
Copy Markdown

@earthling-amzn
8389846: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant