8367008: Algorithm identifiers for HmacSHA* should always have NULL as params - #719
8367008: Algorithm identifiers for HmacSHA* should always have NULL as params#719rm-gh-8 wants to merge 1 commit into
Conversation
|
👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request for backport of JDK-8367008: Algorithm identifiers for HmacSHA* should always have NULL as params. This is PR updates AlgorithmId to treat ASN.1 NULL parameters as no parameters, and updates the list of algorithms that must encode NULL. For parity with Oracle JDK. Low to moderate risk - HMAC algorithm identifiers now encode an explicit NULL (https://www.rfc-editor.org/rfc/rfc9879.html#appendix-B), which could affect interoperability with existing external integrations. |
Backporting JDK-8367008: Algorithm identifiers for HmacSHA* should always have NULL as params.
This is PR updates AlgorithmId to treat ASN.1 NULL parameters as no parameters, and updates the list of algorithms that must encode NULL.
For parity with Oracle JDK.
Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:
make test TEST=test/jdk/sun/security/x509
Results:
windows-x64-specific-test.log
macos-aarch64-specific-test.log
linux-x64-specific-test.log
linux-aarch64-specific-test.log
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/719/head:pull/719$ git checkout pull/719Update a local copy of the PR:
$ git checkout pull/719$ git pull https://git.openjdk.org/jdk25u-dev.git pull/719/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 719View PR using the GUI difftool:
$ git pr show -t 719Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/719.diff
Using Webrev
Link to Webrev Comment