Skip to content

8382150: Shenandoah: Clean up nmethod entry barrier support - #720

Open
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8382150-shen-native-barrier-cleanup
Open

8382150: Shenandoah: Clean up nmethod entry barrier support#720
shipilev wants to merge 1 commit into
openjdk:masterfrom
shipilev:JDK-8382150-shen-native-barrier-cleanup

Conversation

@shipilev

@shipilev shipilev commented Aug 11, 2026

Copy link
Copy Markdown
Member

Additional testing:

  • Linux x86_64 server fastdebug, jcstress 8 hour run
  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah
  • Linux x86_64 server fastdebug, hotspot_gc_shenandoah with -XX:TieredStopAtLevel=1
  • Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC
  • Linux AArch64 server fastdebug, all with -XX:+UseShenandoahGC
  • Linux x86_64 server fastdebug, all with -XX:+UseShenandoahGC -XX:TieredStopAtLevel=1
  • Linux AArch64 server fastdebug, all with -XX:+UseShenandoahGC -XX:TieredStopAtLevel=1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8382150 needs maintainer approval

Issue

  • JDK-8382150: Shenandoah: Clean up nmethod entry barrier support (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/720/head:pull/720
$ git checkout pull/720

Update a local copy of the PR:
$ git checkout pull/720
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/720/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 720

View PR using the GUI difftool:
$ git pr show -t 720

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/720.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 11, 2026

Copy link
Copy Markdown

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 11, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 17ee366ff964ea4e50b419a033bab973c46f601c 8382150: Shenandoah: Clean up nmethod entry barrier support Aug 11, 2026
@openjdk

openjdk Bot commented Aug 11, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 11, 2026
@shipilev
shipilev marked this pull request as ready for review August 12, 2026 14:17
@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 12, 2026
@shipilev

Copy link
Copy Markdown
Member Author

/approval request Simplifies Shenandoah code, removes another intermediate GC state, provides cleaner grounds for more fixes. Applies cleanly. Aggressive testing passes. Risk is low: touches production code, but only makes unsafe corner case safer, does not change the core functionality, no bugtail since several months in mainline.

@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

@shipilev
8382150: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 12, 2026
@mlbridge

mlbridge Bot commented Aug 12, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant