Skip to content

8354242: VectorAPI: combine vector not operation with compare - #725

Open
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8354242-V25
Open

8354242: VectorAPI: combine vector not operation with compare#725
rm-gh-8 wants to merge 1 commit into
openjdk:masterfrom
rm-gh-8:JDK-8354242-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8354242: VectorAPI: combine vector not operation with compare.

This PR implements a C2 JIT optimization that changes a negated Vector API mask compare into a single compare with the opposite predicate.

This is a prerequisite for JDK-8370481 (#728) and JDK-8370794, which are for parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/vectorapi
make test TEST=test/hotspot/jtreg/compiler/c2/irTests

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log

Ran the following benchmark on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

./build/*/images/jdk/bin/java -jar build/*/images/test/micro/benchmarks.jar org.openjdk.bench.jdk.incubator.vector.MaskCompareNotBenchmark

windows-x64-benchmark-test-before-change.log
windows-x64-benchmark-test.log
macos-aarch64-benchmark-test-before-change.log
macos-aarch64-benchmark-test.log
linux-x64-benchmark-test-before-change.log
linux-x64-benchmark-test.log
linux-aarch64-benchmark-test-before-change.log
linux-aarch64-benchmark-test.log

Across all four platforms (linux-aarch64, linux-x64, macos-aarch64, windows-x64), the change did not produce performance regressions.



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8354242 needs maintainer approval

Issue

  • JDK-8354242: VectorAPI: combine vector not operation with compare (Enhancement - P4 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/725/head:pull/725
$ git checkout pull/725

Update a local copy of the PR:
$ git checkout pull/725
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/725/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 725

View PR using the GUI difftool:
$ git pr show -t 725

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/725.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper

bridgekeeper Bot commented Aug 12, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@rm-gh-8
rm-gh-8 marked this pull request as ready for review August 12, 2026 21:09
@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 45cc515f451accfd1a0a36d17ccb38d428a5d035 8354242: VectorAPI: combine vector not operation with compare Aug 12, 2026
@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 12, 2026
@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

⚠️ @rm-gh-8 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk Bot added the rfr Pull request is ready for review label Aug 12, 2026
@rm-gh-8

rm-gh-8 commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8354242: VectorAPI: combine vector not operation with compare.

This PR implements a C2 JIT optimization that changes a negated Vector API mask compare into a single compare with the opposite predicate.

This is a prerequisite for JDK-8370481 and JDK-8370794, which are for parity with Oracle JDK.

Low risk — it is a narrow C2 JIT optimization that includes a new test to validate.

@openjdk

openjdk Bot commented Aug 12, 2026

Copy link
Copy Markdown

@rm-gh-8
8354242: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 12, 2026
@mlbridge

mlbridge Bot commented Aug 12, 2026

Copy link
Copy Markdown

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant