Skip to content

8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP - #730

Open
rm-gh-8 wants to merge 1 commit into
openjdk:pr/728from
rm-gh-8:JDK-8370794-V25
Open

8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP#730
rm-gh-8 wants to merge 1 commit into
openjdk:pr/728from
rm-gh-8:JDK-8370794-V25

Conversation

@rm-gh-8

@rm-gh-8 rm-gh-8 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Backporting JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP.

This PR fixes a regression for vectorized unsigned integer/long equality checks.

For parity with Oracle JDK.

Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64:

make test TEST=test/hotspot/jtreg/compiler/c2/irTests/TestVectorConditionalMove.java
make test TEST=hotspot_compiler

Results:

windows-x64-specific-test.log
windows-x64-specific-2-test.log
macos-aarch64-specific-test.log
macos-aarch64-specific-2-test.log
linux-x64-specific-test.log
linux-x64-specific-2-test.log
linux-aarch64-specific-test.log
linux-aarch64-specific-2-test.log



Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8370794 needs maintainer approval

Integration blocker

 ⚠️ Dependency #728 must be integrated first

Issue

  • JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP (Bug - P2 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk25u-dev.git pull/730/head:pull/730
$ git checkout pull/730

Update a local copy of the PR:
$ git checkout pull/730
$ git pull https://git.openjdk.org/jdk25u-dev.git pull/730/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 730

View PR using the GUI difftool:
$ git pr show -t 730

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk25u-dev/pull/730.diff

Using Webrev

Link to Webrev Comment

@rm-gh-8
rm-gh-8 marked this pull request as ready for review August 14, 2026 12:20
@bridgekeeper

bridgekeeper Bot commented Aug 14, 2026

Copy link
Copy Markdown

👋 Welcome back rmesde! A progress list of the required criteria for merging this PR into pr/728 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk

openjdk Bot commented Aug 14, 2026

Copy link
Copy Markdown

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk Bot changed the title Backport 667744c353e4d6abbe5cbf85746e5e0e44dafaf8 8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP Aug 14, 2026
@openjdk

openjdk Bot commented Aug 14, 2026

Copy link
Copy Markdown

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk Bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Aug 14, 2026
@mlbridge

mlbridge Bot commented Aug 14, 2026

Copy link
Copy Markdown

Webrevs

@rm-gh-8

rm-gh-8 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

/approval request for backport of JDK-8370794: C2 SuperWord: Long/Integer.compareUnsigned return wrong value for EQ/NE in SLP.

This PR fixes a regression for vectorized unsigned integer/long equality checks.

For parity with Oracle JDK.

Low risk — a narrowly-scoped fix for regression in C2.

@openjdk

openjdk Bot commented Aug 14, 2026

Copy link
Copy Markdown

@rm-gh-8
8370794: The approval request has been created successfully.

@openjdk openjdk Bot added the approval Requires approval; will be removed when approval is received label Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approval Requires approval; will be removed when approval is received backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant