Repository navigation
Conversation
3e768ce to
36f85f6
Compare
|
wborn
left a comment
There was a problem hiding this comment.
This is an initial AI-assisted review.
The custom-project workflow improvements look good overall. One deployment safety issue should be addressed before merging: automatic deployments need to wait for lint validation.
There is also a non-blocking suggestion regarding build validation for deployment-only changes.
| # uses: "./.github/workflows/deployment.yml" | ||
| deployment: | ||
| name: Deploy | ||
| needs: [detect-changes, install-dist, unit-tests, integration-tests] |
There was a problem hiding this comment.
The deployment job doesn't depend on check-spotless or ui-check-spotless, so it can start before those checks finish and proceed even if lint fails. Could both lint jobs be added to needs to ensure validation completes successfully before deploying?
| needs: detect-changes | ||
| if: ${{ !failure() && !cancelled() }} | ||
| uses: "./.github/workflows/install-dist.yml" | ||
| uses: "./.github/workflows/custom-install-dist.yml" |
There was a problem hiding this comment.
The new custom-install-dist.yml includes the deployment build, but any_modified still excludes deployment/**. Consequently, deployment-only changes won't trigger the build. Could the change detection be extended to cover those files as well?



Description
Brings the custom project workflows up to date and adds manual deployments. The following has been tested: #2955 (comment)
Decisions
custom-install-dist.yml: the archive steps ininstall-dist.ymlassume the core repo layout (e.g.ui/util) and fail in custom projects. Nothing in the custom pipelines downloads those artifacts, so the custom build only runsinstallDist. It includes the deployment, so a broken deployment build shows up in review..ci_cd/ci_cd.jsonhas a deploy entry for the pushed branch, as in the oldci_cd.yml. Without this check,deployment.ymlfails on projects without deploy config.deploy.shversions: custom projects rundeploy.shfrom theiropenremoteversion. Up to 1.32.0 that script readsIS_MAIN_REPOandopenremote/.ci_cd, sodeployment.ymlnow provides both, likeci_cd.ymldoes. Without them host init is silently skipped.custom-deploy.ymlwrapper: custom projects call this instead ofdeploy.ymlordeployment.yml, so they don't depend on thedeployment.ymlworkflow (inputs), which we plan to change in Investigate how to simplify the deployment workflows #2801.code-coverage.ymlneeds JaCoCo outputs and thecombinedCoverageReporttask. Adopting it means running it only for custom projects that support it.Warning
The(This has now been tested)GFE_PASSWORDmechanism for decrypting encrypted deployment files has not been tested.Changelog
custom-install-dist.ymlthat builds custom projects without archiving core build outputscustom-install-dist.ymlincustom-review.ymlandcustom-staging.ymlcustom-staging.ymlwhen.ci_cd/ci_cd.jsonconfigures a deploy for the branchdeploy.shfrom releases up to 1.32.0 indeployment.ymlcustom-deploy.ymlfor manual deployments from custom projectsChecklist