Leave a Groovy def declaration alone instead of splicing var into its variable name. - #1229
Open
motlin wants to merge 1 commit into
Open
Leave a Groovy def declaration alone instead of splicing var into its variable name.#1229motlin wants to merge 1 commit into
def declaration alone instead of splicing var into its variable name.#1229motlin wants to merge 1 commit into
Conversation
Contributor
Author
|
See also liftwizard/liftwizard#4125 |
… its variable name.
motlin
force-pushed
the
groovy-def-var-splice
branch
from
September 1, 2026 00:41
03573b5 to
19833ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's changed?
DeclarationCheck.isSingleVariableDefinitionnow refuses declarations that expose no type expression forvarto replace. The single guard coversUseVarForConstructors,UseVarForObject,UseVarForGenericsConstructors, andUseVarForGenericMethodInvocations.What's your motivation?
The
varrecipes corrupt Groovydefdeclarations, non-idempotently.Originally hit on
rewrite-migrate-java3.42.1 withrewrite-maven-plugin6.46.1, against a realMaven archetype post-generate script. Still reproduces on
mainatv3.43.0.Anything in particular you'd like reviewers to focus on?
Have you considered any alternatives or workarounds?
Applying an
org.openrewrite.FindSourceFilesprecondition of**/*.javato thevarrecipes.