Add CleanupTryWithResources - #1046
Open
sullis wants to merge 1 commit into
Open
Conversation
sullis
force-pushed
the
cleanup-try-with-resources
branch
from
September 1, 2026 19:47
786932a to
3dba993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
CleanupTryWithResourcesrecipe that removes the redundantfinalmodifier from resources declared in a try-with-resources statement. Such resources are implicitly final (JLS 14.20.3), so the modifier adds no meaning.Notes on the implementation:
JavaFileChecker.finalis collapsed back onto one line. Initializers keep their own layout, so a multi-linenew ...(...)is not reflowed.finalmodifier that carries its own annotations is left alone, since dropping it would lose them.META-INF/rewrite/recipes.csv; it is intentionally not added tocommon-static-analysis.yml.Test coverage (
CleanupTryWithResourcesTest, 12 cases):finalfinaland the type, between an annotation andfinal, and a line comment with its line breakfinal, and a resource referencing an existing variable🤖 Generated with Claude Code