Resolve org.openrewrite build plugins from the Code Genome Project - #1047
Merged
Conversation
Co-authored-by: Moderne <team@moderne.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / problem
rewrite-build-gradle-plugin2.23.2 depends on rewrite releases published only to the Code Genome Project, but this repository resolves its plugin classpath from the Gradle Plugin Portal alone, so configuration fails withCould not find org.openrewrite:rewrite-java:8.91.4before any convention plugin runs. This is item (d) of moderneinc/customer-requests#2788.Solution
pluginManagement.repositories, scoped to theorg.openrewriteandio.modernegroups, with credentials from thecodegenomeUsernameandcodegenomePasswordGradle properties or theCODEGENOME_USERNAMEandCODEGENOME_TOKENenvironment variables, which CI already provides throughgh-automation. Applied byio.moderne.recipe.AddCodeGenomePluginRepository; the same block is already green in Replace the Log4j setLevel Refaster template with its generated recipe rewrite-logging-frameworks#304.Test plan
Use this link to re-run the recipe: https://dev.moderne.io/recipes/io.moderne.recipe.AddCodeGenomePluginRepository?organizationId=VXNlcnMva2V2aW5AbW9kZXJuZS5pby9NK08%3D