-
Notifications
You must be signed in to change notification settings - Fork 21
Add rrsync sidecar docker image #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mwestphall
wants to merge
2
commits into
opensciencegrid:main
Choose a base branch
from
mwestphall:INF-3810-artifacts-server-rsync-sidecar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Host keys are generated at container start (see entrypoint.sh) into a | ||
| # dedicated directory rather than baked into the image or the default | ||
| # /etc/ssh location. | ||
| HostKey /etc/ssh/keys/ssh_host_rsa_key | ||
| HostKey /etc/ssh/keys/ssh_host_ecdsa_key | ||
| HostKey /etc/ssh/keys/ssh_host_ed25519_key |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # Restrict all SSH sessions to rsync-over-ssh; no interactive shell access. | ||
| ForceCommand /usr/bin/rrsync /data | ||
| PermitTTY no | ||
| X11Forwarding no | ||
| AllowTcpForwarding no | ||
| AllowAgentForwarding no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| FROM almalinux:9 | ||
|
|
||
| LABEL maintainer="OSG Software <help@osg-htc.org>" | ||
|
|
||
| RUN --mount=type=cache,id=dnf-9,target=/var/cache/dnf,sharing=locked \ | ||
| dnf install -y openssh-server rsync-rrsync | ||
|
|
||
| RUN mkdir /data | ||
|
|
||
| RUN mkdir -p -m0755 /run/sshd && \ | ||
| mkdir -p -m0700 /root/.ssh && \ | ||
| mkdir -p -m0700 /etc/ssh/keys | ||
|
|
||
| COPY --chown=root:root --chmod=0644 10-rsync.conf /etc/ssh/sshd_config.d/10-rsync.conf | ||
| COPY --chown=root:root --chmod=0644 05-hostkeys.conf /etc/ssh/sshd_config.d/05-hostkeys.conf | ||
| COPY --chown=root:root --chmod=0755 entrypoint.sh /entrypoint.sh | ||
|
|
||
| CMD ["/entrypoint.sh"] | ||
|
|
||
| EXPOSE 22/tcp | ||
| VOLUME /data | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| rsync-over-ssh sidecar | ||
| ====================== | ||
|
|
||
| Runs an sshd server intended to be deployed as a sidecar container in a | ||
| Kubernetes Pod, allowing external clients to write to a shared volume via | ||
| rsync over ssh. | ||
|
|
||
| To permit login, volume-mount an `authorized_keys` file into | ||
| `/root/.ssh/authorized_keys`. | ||
| Mount the target data volume into `/data`. | ||
|
|
||
| sshd is configured (see `10-rsync.conf`) to reject interactive shell | ||
| access: every session is forced through [`rrsync`](https://download.samba.org/pub/rsync/rrsync.1). | ||
| which restricts the client to rsync operations rooted at `/data` and | ||
| rejects anything else. | ||
|
|
||
| Example usage: | ||
|
|
||
| ``` | ||
| docker run --detach --name rrsync \ | ||
| -v ~/authorized_keys:/root/.ssh/authorized_keys \ | ||
| -v ~/mydata:/data \ | ||
| -p2222:22 rrsync | ||
| rsync -e "ssh -p 2222" myfile.txt root@localhost:/ | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| #!/bin/sh | ||
| set -e | ||
|
|
||
| KEY_DIR=/etc/ssh/keys | ||
|
|
||
| if [ ! -f "$KEY_DIR/ssh_host_rsa_key" ]; then | ||
| for type in rsa ecdsa ed25519; do | ||
| ssh-keygen -q -t "$type" -f "$KEY_DIR/ssh_host_${type}_key" -N '' | ||
| done | ||
| fi | ||
|
|
||
| exec /usr/sbin/sshd -D -e |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You might need to create
/run/sshdin the entryping, since/runcan be a tmpfs.