Repository navigation
Windows builds from the scoped npm packages - #20
Conversation
curl -fsSL https://pi-bolt.opensec.in/install.cmd -o install.cmd && install.cmd && del install.cmd runs install.ps1 in Windows PowerShell; publish puts it on the site next to install.sh and install.ps1.
…-bolt-win32-* npm does not accept the unscoped names; the scoped ones hold the same release .zip, checked against the signed SHA256SUMS as before. Releases without them still come from GitHub.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Command Prompt keeps powershell -c "irm https://pi-bolt.opensec.in/install.ps1 | iex".
Kushalkhemka
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 238193cea2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| rem | ||
| rem It runs install.ps1 in Windows PowerShell, which downloads a release, verifies its checksum and signature and installs | ||
| rem it. Its environment variables (PIBOLT_VERSION, PIBOLT_VARIANT, ...) work here too. | ||
| powershell -c "irm https://pi-bolt.opensec.in/install.ps1 | iex" |
There was a problem hiding this comment.
When install.ps1 catches an installation failure such as a checksum mismatch, its final handler assigns $global:LASTEXITCODE = 1 and completes normally. powershell -Command determines its process status from $?, not from a manually assigned $LASTEXITCODE; Microsoft's documentation explicitly requires exit $LASTEXITCODE to preserve that value. Consequently this command returns 0, line 9 propagates success, and the documented && del install.cmd continues despite the failed installation; append ; exit $LASTEXITCODE to the PowerShell command.
Useful? React with 👍 / 👎.
install.ps1downloads Windows builds from the npm packages@kushalkhemka/pi-bolt-win32-x64and-x64-jit(published for 0.8.5, same.zipas the release, checked against the signedSHA256SUMS). npm does not accept the unscoped names. Releases without them come from GitHub as before.Published by re-running
publish.ymlforbolt-v0.8.5(no new release).npm install -g pi-bolton Windows keeps downloading from GitHub until the next release, whosenpm/install.cjsandpublish-npm-builds.shwill use the scoped names.