feat: add sync-kme-assets to import KME deploy from GitHub - #334
Open
michalskrivanek wants to merge 1 commit into
Open
feat: add sync-kme-assets to import KME deploy from GitHub#334michalskrivanek wants to merge 1 commit into
michalskrivanek wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
/cc @tiraboschi |
michalskrivanek
force-pushed
the
sync-kme
branch
from
August 24, 2026 06:55
9d4619e to
df6b90f
Compare
Add hack/sync-kme-assets.sh with make sync-kme-assets and verify-kme-assets targets. Fetches kubevirt-metrics-exporter deploy manifests and applies autopilot transforms (DaemonSet template, namespace monitoring label). Remove redundant metrics-exporter env override unit tests. Signed-off-by: Michal Skrivanek <michal.skrivanek@redhat.com> Assisted-by: composer-auto
michalskrivanek
force-pushed
the
sync-kme
branch
from
August 24, 2026 06:59
df6b90f to
4d1eb46
Compare
tiraboschi
reviewed
Aug 25, 2026
Comment on lines
+91
to
+109
| namespace_yaml() { | ||
| cat <<'EOF' | ||
| apiVersion: v1 | ||
| kind: Namespace | ||
| metadata: | ||
| name: kubevirt-metrics-exporter | ||
| labels: | ||
| openshift.io/cluster-monitoring: "true" | ||
| EOF | ||
| } | ||
|
|
||
| write_namespace_file() { | ||
| local dest=$1 | ||
| local tmp | ||
| tmp="$(mktemp)" | ||
| namespace_yaml > "${tmp}" | ||
| write_or_compare_file "${dest}" "${tmp}" | ||
| rm -f "${tmp}" | ||
| } |
Member
There was a problem hiding this comment.
can't we simply add openshift.io/cluster-monitoring: "true" to https://github.com/openshift-virtualization/kubevirt-metrics-exporter/blob/main/deploy/base/namespace.yaml ?
| |---|---| | ||
| | `deploy/base/daemonset.yaml` | `kubevirt-metrics-exporter.yaml.tpl` | | ||
| | `deploy/base/namespace.yaml` | `namespace.yaml` (+ monitoring label) | | ||
| | `deploy/openshift/datasource.yaml` | `datasource.yaml` | |
Member
There was a problem hiding this comment.
I don't think we are transforming this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add hack/sync-kme-assets.py with make sync-kme-assets and verify-kme-assets targets. Fetches kubevirt-metrics-exporter deploy manifests and applies autopilot transforms (DaemonSet template, namespace monitoring label). Remove redundant metrics-exporter env override unit tests.