Skip to content

SRVOCF-1071: Change the delete action to an undeploy button - #181

Open
Cragsmann wants to merge 1 commit into
openshift:masterfrom
Cragsmann:SRVOCF-1071-change-the-delete-to-an-undeploy-button-and-update
Open

SRVOCF-1071: Change the delete action to an undeploy button#181
Cragsmann wants to merge 1 commit into
openshift:masterfrom
Cragsmann:SRVOCF-1071-change-the-delete-to-an-undeploy-button-and-update

Conversation

@Cragsmann

Copy link
Copy Markdown

Summary

  • 🔧 Rename the function row "Delete" action to "Undeploy": swap the trash icon for a power-off icon, add an "Undeploy" tooltip on the enabled button, and explain in the confirmation modal that undeploying removes the running function and its Knative Service while leaving the GitHub repository intact.
  • 📚 Add an "Undeploy a function" step to the setup guide and fix the guide title ("Set up guide" to "Setup guide").
  • 🧪 Update unit and e2e tests and locale strings to match the new action.

Fixes SRVOCF-1071

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)
  • Updated docs/TESTING.md (if there are relevant changes to our testing framework or setup)

Rename the per-row delete icon button to an undeploy (power off) button
with a custom confirmation message that clarifies the GitHub repository
and code are preserved. Add an undeploy step to the setup guide and fix
the guide title wording.

Refs: SRVOCF-1071

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 3, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 3, 2026

Copy link
Copy Markdown

@Cragsmann: This pull request references SRVOCF-1071 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • 🔧 Rename the function row "Delete" action to "Undeploy": swap the trash icon for a power-off icon, add an "Undeploy" tooltip on the enabled button, and explain in the confirmation modal that undeploying removes the running function and its Knative Service while leaving the GitHub repository intact.
  • 📚 Add an "Undeploy a function" step to the setup guide and fix the guide title ("Set up guide" to "Setup guide").
  • 🧪 Update unit and e2e tests and locale strings to match the new action.

Fixes SRVOCF-1071

Checklist

  • Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)
  • Updated docs/TESTING.md (if there are relevant changes to our testing framework or setup)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign twogiants for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 3, 2026

Copy link
Copy Markdown

@Cragsmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants