SRVOCF-859: Set S2I builder in generated GitHub CI workflow

[pmeida]

Summary

• Set builders.S2I as the builder in the WorkflowConfig passed to the GitHub CI workflow generator, so generated workflows include FUNC_BUILDER: s2i and produce Red Hat UBI-based images
• Add a test assertion verifying the generated workflow YAML contains FUNC_BUILDER: s2i
• Bump knative.dev/func to pick up knative/func#4033, which added the Builder field to WorkflowConfig and made this change possible

Until e2e tests cover the generated CI workflow, manual tests were performed across all supported runtimes (node, python, go, quarkus) to verify the generated workflow contains the correct builder configuration.

Fixes SRVOCF-859

Checklist

• Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)
• Updated docs/TESTING.md (if there are relevant changes to our testing framework or setup)

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@pmeida: This pull request references SRVOCF-859 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• Set builders.S2I as the builder in the WorkflowConfig passed to the GitHub CI workflow generator, so generated workflows include FUNC_BUILDER: s2i and produce Red Hat UBI-based images
• Add a test assertion verifying the generated workflow YAML contains FUNC_BUILDER: s2i
• Bump knative.dev/func to pick up knative/func#4033, which added the Builder field to WorkflowConfig and made this change possible; also bumps k8s.io/* to v0.35.8

Until e2e tests cover the generated CI workflow, manual tests were performed across all supported runtimes (node, python, go, quarkus) to verify the generated workflow contains the correct builder configuration.

Fixes SRVOCF-859

Checklist

• Updated docs/ARCHITECTURE.md (if there are relevant changes to our layered architecture)
• Updated docs/TESTING.md (if there are relevant changes to our testing framework or setup)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign twogiants for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@pmeida: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.