Skip to content

OKD-453: Dockerfile.openshift: conditionally install frr or frr10 based on OS version - #137

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:fix-frr-package-centos-stream10
Open

OKD-453: Dockerfile.openshift: conditionally install frr or frr10 based on OS version#137
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:fix-frr-package-centos-stream10

Conversation

@redhat-chai-bot

Copy link
Copy Markdown

On CentOS Stream 10 (and RHEL 10), FRR version 10 is the default
package named frr. The separate frr10 package does not exist.

This causes builds to fail when the base image is CentOS Stream 10,
because dnf install frr10 cannot find the package.

This change detects the OS major version from /etc/os-release and
installs frr on version 10+ (where FRR 10 is the default) or
frr10 on version 9 (where it exists as a separate package).


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

…version

On CentOS Stream 10 / RHEL 10, FRR version 10 is the default `frr`
package and `frr10` does not exist as a separate package. Detect the
OS major version by sourcing /etc/os-release and install `frr` when
VERSION_ID starts with "10", falling back to `frr10` for older
releases (CentOS Stream 9 / RHEL 9).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign cgoncalves for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Prashanth684

Copy link
Copy Markdown

This fixes OKD builds which have already moved to using centos stream10 base images

@Prashanth684
Prashanth684 requested a review from oribon September 9, 2026 18:44
@Prashanth684

Copy link
Copy Markdown

/verified by @Prashanth684

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 9, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@Prashanth684: This PR has been marked as verified by @Prashanth684.

Details

In response to this:

/verified by @Prashanth684

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Prashanth684 Prashanth684 changed the title Dockerfile.openshift: conditionally install frr or frr10 based on OS version OKD-453: Dockerfile.openshift: conditionally install frr or frr10 based on OS version Sep 9, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 9, 2026

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references OKD-453 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

On CentOS Stream 10 (and RHEL 10), FRR version 10 is the default
package named frr. The separate frr10 package does not exist.

This causes builds to fail when the base image is CentOS Stream 10,
because dnf install frr10 cannot find the package.

This change detects the OS major version from /etc/os-release and
installs frr on version 10+ (where FRR 10 is the default) or
frr10 on version 9 (where it exists as a separate package).


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants