OKD-453: Dockerfile.openshift: conditionally install frr or frr10 based on OS version - #137
Conversation
…version On CentOS Stream 10 / RHEL 10, FRR version 10 is the default `frr` package and `frr10` does not exist as a separate package. Detect the OS major version by sourcing /etc/os-release and install `frr` when VERSION_ID starts with "10", falling back to `frr10` for older releases (CentOS Stream 9 / RHEL 9). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@redhat-chai-bot: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
This fixes OKD builds which have already moved to using centos stream10 base images |
|
/verified by @Prashanth684 |
|
@Prashanth684: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@redhat-chai-bot: This pull request references OKD-453 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
On CentOS Stream 10 (and RHEL 10), FRR version 10 is the default
package named
frr. The separatefrr10package does not exist.This causes builds to fail when the base image is CentOS Stream 10,
because
dnf install frr10cannot find the package.This change detects the OS major version from
/etc/os-releaseandinstalls
frron version 10+ (where FRR 10 is the default) orfrr10on version 9 (where it exists as a separate package).AI-generated. Review for accuracy.
@Prashanth684 requested in Slack thread