no-jira: images: bump upi to 5.0#10615
Conversation
Followup to ART automated PRs to bump images to 5.0; the bot does not bump to a new version, so we need to do it.
|
@patrickdillon: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note
|
| Layer / File(s) | Summary |
|---|---|
Artifact and builder stage image updates images/installer/Dockerfile.upi.ci |
Artifact-copy stages and Go builder stage reference are switched from OpenShift 4.22 to 5.0 image tags, with the builder base image updated to the 5.0 variant. |
Toolchain stage image updates images/installer/Dockerfile.upi.ci |
Toolchain-related stages for CLI and base-rhel9 are updated to reference OpenShift 5.0 images instead of 4.22 variants; external tool images (govc, pwsh, yq) remain from their original registries. |
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: bumping UPI Dockerfile images from 4.22 to OpenShift 5.0. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
| Linked Issues check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | ✅ Passed | Check skipped because no linked issues were found for this pull request. |
| Stable And Deterministic Test Names | ✅ Passed | PR modifies only Dockerfile.upi.ci with static image version references; no Ginkgo test files or test names are present, making this check inapplicable. |
| Test Structure And Quality | ✅ Passed | PR modifies only Dockerfile.upi.ci (Docker image references), not Ginkgo test code. Custom check for test structure is inapplicable to infrastructure/build configuration changes. |
| Microshift Test Compatibility | ✅ Passed | PR only modifies Dockerfile for CI infrastructure (images/installer/Dockerfile.upi.ci); no new Ginkgo e2e tests were added, so MicroShift test compatibility check is not applicable. |
| Single Node Openshift (Sno) Test Compatibility | ✅ Passed | This PR updates only Dockerfile image references (4.22→5.0) and includes no new Ginkgo e2e tests. The SNO compatibility check is not applicable. |
| Topology-Aware Scheduling Compatibility | ✅ Passed | PR only modifies a Dockerfile's image version references (4.22→5.0); no deployment manifests, operator code, controllers, or scheduling constraints are added/modified. |
| Ote Binary Stdout Contract | ✅ Passed | PR only modifies Dockerfile image references (4.22→5.0); no Go source code or executable binaries changed. OTE Binary Stdout Contract check is inapplicable to Dockerfile-only changes. |
| Ipv6 And Disconnected Network Test Compatibility | ✅ Passed | PR modifies only Dockerfile.upi.ci with image version updates; no Ginkgo e2e tests are added, making the test compatibility check not applicable. |
| No-Weak-Crypto | ✅ Passed | PR updates Dockerfile.upi.ci to OpenShift 5.0 images; no weak crypto patterns (MD5, SHA1, DES, RC4, etc.) detected. Uses modern cryptography and pyOpenSSL packages as required dependencies. |
| Container-Privileges | ✅ Passed | Dockerfile contains no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation directives; container runs as non-root user 1000:1000. |
| No-Sensitive-Data-In-Logs | ✅ Passed | No logging exposing passwords, tokens, API keys, PII, or other sensitive data found. Existing logging statements (Google Cloud repo config, curl flags, version/plugin output) contain only non-sensi... |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
Comment @coderabbitai help to get the list of available commands and usage tips.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@patrickdillon: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| FROM registry.ci.openshift.org/ocp/5.0:installer-etcd-artifacts AS etcd-artifacts | ||
|
|
||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | ||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-5.0 AS builder |
There was a problem hiding this comment.
Should we use go v1.26 image like others? It seems fine even though installer is on 1.25...
Followup to ART automated PRs to bump images to 5.0; the bot does not bump to a new version, so we need to do it.
Summary by CodeRabbit