unit tests: remove stale UserProvisionedDNS feature gate test

[redhat-chai-bot]

The AWSClusterHostedDNSInstall feature gate was removed in openshift/api#2775, so userProvisionedDNS is no longer feature-gated.

This removes the now-stale test case "AWS UserProvisionedDNS is not allowed without Feature Gates" from featuregate_test.go, along with the unused dns import that was only referenced by that test case.

The corresponding validation logic in featuregates.go has already been updated and no longer checks for this feature gate.

Summary by CodeRabbit

• Tests
  • Updated validation tests to reflect the current supported feature-gate behavior.
  • Removed an outdated test case and related unused test dependency.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f1e0b899-4a89-4c03-aa27-91e04796ea82

📥 Commits

Reviewing files that changed from the base of the PR and between a34cc48 and 268206b.

📒 Files selected for processing (1)

• pkg/types/validation/featuregate_test.go

💤 Files with no reviewable changes (1)

• pkg/types/validation/featuregate_test.go

---

📝 Walkthrough

Walkthrough

The feature gate validation test removes an unused DNS import and deletes the AWS UserProvisionedDNS case that expected a forbidden error without the required AWS feature gates.

Changes

Feature gate test cleanup

Layer / File(s)	Summary
Test case cleanup pkg/types/validation/featuregate_test.go	The test file drops the unused DNS import and removes the AWS UserProvisionedDNS forbidden-case assertion from TestFeatureGates.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: removing the stale UserProvisionedDNS feature gate unit test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All remaining test titles are static string literals passed via tc.name; no dynamic or generated values appear, and the removed case was static too.
Test Structure And Quality	✅ Passed	PASS: The PR only deletes a stale DNS feature-gate test and unused import; it introduces no new test-structure, cleanup, timeout, or assertion-quality issues.
Microshift Test Compatibility	✅ Passed	The PR only removes a stale unit test and an unused import; no new Ginkgo e2e tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	Touched file is a unit test (TestFeatureGates with testing.T), not a new Ginkgo e2e test, and no SNO-specific multi-node assumptions were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only GCP machine-pool defaulting and a stale test removal changed; no manifests, controllers, or pod-scheduling constraints were introduced.
Ote Binary Stdout Contract	✅ Passed	PASS: The PR only removes a stale unit test and an unused import in featuregate_test.go; no process-level stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR only removes a unit-test case/import in pkg/types/validation/featuregate_test.go; it adds no Ginkgo e2e tests or IPv4/network assumptions.
No-Weak-Crypto	✅ Passed	Touched test file contains no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or secret-comparison code; patch only removes a stale DNS feature-gate test/import.
Container-Privileges	✅ Passed	PR only removes a stale unit test/import in featuregate_test.go; no pod/container manifests or privilege fields were added.
No-Sensitive-Data-In-Logs	✅ Passed	The only touched file is a unit test, and it contains no logging or secret-bearing output paths; the removed case/import also add no exposure risk.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/golint	268206b	link	true	/test golint
ci/prow/e2e-aws-ovn	268206b	link	true	/test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[miyadav]

/close .
included this change in - #10618