Skip to content

[release-4.20] SPLAT-2867: Add vSphere cloud config modules from 3CMO - #2469

Open
vr4manta wants to merge 7 commits into
openshift:release-4.20from
vr4manta:SPLAT-2867
Open

vr4manta wants to merge 7 commits into
openshift:release-4.20from
vr4manta:SPLAT-2867

Conversation

@vr4manta

Copy link
Copy Markdown
Contributor

SPLAT-2867

Changes

  • Migrated 3CMO vSphere cloud config modules to library-go
  • Changed Node struct to not be a pointer in CPIConfig
  • Removed yaml tags from fields in favor of json tags

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

(cherry picked from commit 8cf66b8)
(cherry picked from commit acdf659)
(cherry picked from commit 57a1b81)
… v1.38.2

The vsphere config test package added by the SPLAT-2651 backport
(openshift#2175/openshift#2195) is the first consumer of the already-declared
github.com/onsi/gomega v1.38.2 dependency, which was previously
unused and unvendored. `go mod tidy`/`go mod vendor` add the missing
go.sum entries and bump go-logr/logr, google/pprof,
google.golang.org/protobuf, and the golang.org/x/{net,sys,text,tools}
family to the minimum versions gomega v1.38.2's own go.mod requires.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 11, 2026
@openshift-ci-robot

openshift-ci-robot commented Sep 11, 2026

Copy link
Copy Markdown

@vr4manta: This pull request references SPLAT-2867 which is a valid jira issue.

Details

In response to this:

SPLAT-2867

Changes

  • Migrated 3CMO vSphere cloud config modules to library-go
  • Changed Node struct to not be a pointer in CPIConfig
  • Removed yaml tags from fields in favor of json tags

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2026
@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d5b423f8-c3b7-41e7-ae75-04d47ac763ae

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vr4manta
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vr4manta vr4manta changed the title WIP: [release-4.20] SPLAT-2867: Add vSphere cloud config modules from 3CMO [release-4.20] SPLAT-2867: Add vSphere cloud config modules from 3CMO Sep 11, 2026
@vr4manta
vr4manta marked this pull request as ready for review September 11, 2026 12:31
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 11, 2026
@openshift-ci
openshift-ci Bot requested review from deads2k and elmiko September 11, 2026 12:32
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants