Skip to content

OTA-1927: Update cluster-updates-critical queries to match console - #3060

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fao89:updateevals
Aug 26, 2026
Merged

OTA-1927: Update cluster-updates-critical queries to match console#3060
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
fao89:updateevals

Conversation

@fao89

@fao89 fao89 commented Aug 14, 2026

Copy link
Copy Markdown
Member

Align the cluster-updates-critical eval queries with the prompts used by the console. conv_001 was 37,384 chars, over the 32,000-char LLMRequest.query cap, so /v1/query returned HTTP 422 and the eval logged an ERROR that tripped test_cluster_updates.

Fixes the periodic CI job:
https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-lightspeed-service-main-4.21-ols-cluster-updates-periodics

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Signed-off-by: Fabricio Aguiar fabricio.aguiar@gmail.com

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Align the cluster-updates-critical eval queries with the prompts used by
the console. conv_001 was 37,384 chars, over the 32,000-char
LLMRequest.query cap, so /v1/query returned HTTP 422 and the eval logged
an ERROR that tripped test_cluster_updates.

Fixes the periodic CI job:
https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-lightspeed-service-main-4.21-ols-cluster-updates-periodics

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 14, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 14, 2026

Copy link
Copy Markdown

@fao89: This pull request references OTA-1927 which is a valid jira issue.

Details

In response to this:

Align the cluster-updates-critical eval queries with the prompts used by the console. conv_001 was 37,384 chars, over the 32,000-char LLMRequest.query cap, so /v1/query returned HTTP 422 and the eval logged an ERROR that tripped test_cluster_updates.

Fixes the periodic CI job:
https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-lightspeed-service-main-4.21-ols-cluster-updates-periodics

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com
Signed-off-by: Fabricio Aguiar fabricio.aguiar@gmail.com

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED

Description

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

💤 Files selected but had no reviewable changes (1)
  • eval/eval_data_cluster_updates.yaml
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d70d3cce-13bd-4c92-8bac-87e15f7f0a07

📥 Commits

Reviewing files that changed from the base of the PR and between ccba5eb and 0fda0d9.

📒 Files selected for processing (1)
  • eval/eval_data_cluster_updates.yaml

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from onmete and raptorsun August 14, 2026 16:25
@fao89

fao89 commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

/cc @JoaoFula @sriroopar

@openshift-ci
openshift-ci Bot requested review from JoaoFula and sriroopar August 21, 2026 15:01
@JoaoFula

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2026
@fao89

fao89 commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@sriroopar could you please approve?

@sriroopar sriroopar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR fixes the query length overflow for cluster updates periodic CI job to pass.

@sriroopar

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sriroopar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown

@fao89: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 22dd222 into openshift:main Aug 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants