[release-4.22] OCPBUGS-109638: Fix clock_state metric: HOLDOVER mapped to 0, stale when CEP enabled

[jzding]

Summary

Backport of upstream PR k8snetworkplumbingwg/linuxptp-daemon#250 to release-4.22.

Two fixes for the openshift_ptp_clock_state Prometheus metric:

• HOLDOVER mapped to 0 instead of 2 — updateClockStateMetrics only distinguished LOCKED (1) from everything else (0). HOLDOVER was indistinguishable from FREERUN despite the help text declaring 0 = FREERUN, 1 = LOCKED, 2 = HOLDOVER. Replaced the if/else with a switch using typed constants shared between metrics.go and event.go.

• Metric stale when CEP enabled — EventHandler.UpdateClockStateMetrics was guarded by if e.stdoutToSocket { return }, skipping Prometheus updates when cloud-event-proxy was enabled. Since CEP does not register its own openshift_ptp_clock_state gauge, this left the metric stale. Removed the guard so the metric is always updated.

Test plan

• TestUpdateClockStateMetrics — verifies FREERUN→0, LOCKED→1, HOLDOVER→2
• go build ./... passes
• Lab tested on cnfdg32 (OCP 4.22) with upstream PR

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-95587, which is invalid:

• expected the bug to be open, but it isn't
• expected the bug to target either version "4.22.0." or "openshift-4.22.0.", but it targets "5.0.0" instead
• expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Done) instead
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-95587 to depend on a bug targeting a version in 5.0.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of upstream PR k8snetworkplumbingwg/linuxptp-daemon#250 to release-4.22.

Two fixes for the openshift_ptp_clock_state Prometheus metric:

• HOLDOVER mapped to 0 instead of 2 — updateClockStateMetrics only distinguished LOCKED (1) from everything else (0). HOLDOVER was indistinguishable from FREERUN despite the help text declaring 0 = FREERUN, 1 = LOCKED, 2 = HOLDOVER. Replaced the if/else with a switch using typed constants shared between metrics.go and event.go.

• Metric stale when CEP enabled — EventHandler.UpdateClockStateMetrics was guarded by if e.stdoutToSocket { return }, skipping Prometheus updates when cloud-event-proxy was enabled. Since CEP does not register its own openshift_ptp_clock_state gauge, this left the metric stale. Removed the guard so the metric is always updated.

Fixes: OCPBUGS-95587

Test plan

• TestUpdateClockStateMetrics — verifies FREERUN→0, LOCKED→1, HOLDOVER→2
• go build ./... passes
• Lab tested on cnfdg32 (OCP 4.22) with upstream PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jzding]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-109638, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected dependent Jira Issue OCPBUGS-95587 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport of upstream PR k8snetworkplumbingwg/linuxptp-daemon#250 to release-4.22.

Two fixes for the openshift_ptp_clock_state Prometheus metric:

• HOLDOVER mapped to 0 instead of 2 — updateClockStateMetrics only distinguished LOCKED (1) from everything else (0). HOLDOVER was indistinguishable from FREERUN despite the help text declaring 0 = FREERUN, 1 = LOCKED, 2 = HOLDOVER. Replaced the if/else with a switch using typed constants shared between metrics.go and event.go.

• Metric stale when CEP enabled — EventHandler.UpdateClockStateMetrics was guarded by if e.stdoutToSocket { return }, skipping Prometheus updates when cloud-event-proxy was enabled. Since CEP does not register its own openshift_ptp_clock_state gauge, this left the metric stale. Removed the guard so the metric is always updated.

Fixes: OCPBUGS-95587

Test plan

• TestUpdateClockStateMetrics — verifies FREERUN→0, LOCKED→1, HOLDOVER→2
• go build ./... passes
• Lab tested on cnfdg32 (OCP 4.22) with upstream PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jzding]

/jira refresh

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-109638, which is invalid:

• expected dependent Jira Issue OCPBUGS-95587 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jzding]

/jira refresh

[openshift-ci-robot]

@jzding: This pull request references Jira Issue OCPBUGS-109638, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-95587 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-95587 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

Requesting review from QA contact:
/cc @dpopsuev

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: dpopsuev.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@jzding: This pull request references Jira Issue OCPBUGS-109638, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-95587 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-95587 targets the "5.0.0" version, which is one of the valid target versions: 5.0.0
• bug has dependents

Requesting review from QA contact:
/cc @dpopsuev

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@jzding: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.