OCPBUGS-92811: Inject proxy into MCC deployment

[djoshy]

- What I did
Per suggestion on OCPBUGS-92811, I added an annotation on the MCC deployment to help facilitate OVA downloads when the cluster is using a proxy.

- How to verify it
OVA downloads should succeed during vsphere bootimage updates when the cluster is using a proxy.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Walkthrough

The machine-config-controller Deployment manifest adds a pod-template annotation to enable OpenShift proxy injection.

Changes

Proxy injection annotation

Layer / File(s)	Summary
Deployment annotation manifests/machineconfigcontroller/deployment.yaml	Adds config.openshift.io/inject-proxy: machine-config-controller under the Deployment pod template annotations.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 warning)

Check name	Status	Explanation	Resolution
No-Sensitive-Data-In-Logs	❌ Error	New test logs print registry domains and the full allowedRegistriesPatch, plus VM/node names; these can expose internal hostnames in CI logs.	Redact or remove the registry/host values from logger.Infof/klog.Infof calls, and avoid logging full patch payloads or resource names.
Test Structure And Quality	⚠️ Warning	The new Ginkgo suite in test/extended-priv/mco_layering.go has bare o.Expect(...).To(o.Succeed()) waits (e.g. WaitForUpdatedStatus) with no diagnostic messages.	Add explicit failure messages to these status waits (and any similar assertions) so failures identify which pool/state step stalled; keep the existing timeouts.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely summarizes the main change: injecting proxy settings into the MCC deployment.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	Changed test titles are static strings; no It/Describe/Context/When names use timestamps, UUIDs, node/ns names, or concatenation.
Microshift Test Compatibility	✅ Passed	Only a YAML deployment manifest changed; the targeted subtree has no Ginkgo It/Describe/Context/When tests, so MicroShift compatibility isn’t implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR only updates a deployment manifest to inject proxy config; no new Ginkgo e2e tests or SNO-sensitive test logic were added.
Topology-Aware Scheduling Compatibility	✅ Passed	Only adds a proxy-injection annotation to an existing Deployment; no new anti-affinity, spread constraints, replica changes, or node selectors were introduced.
Ote Binary Stdout Contract	✅ Passed	Only a Deployment manifest changed; no process-level binary code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	Only manifests/machineconfigcontroller/deployment.yaml changed; no new/modified Ginkgo e2e tests or network-dependent test code were added.
No-Weak-Crypto	✅ Passed	The only change is a proxy-injection annotation in deployment.yaml; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges	✅ Passed	The deployment change only adds the proxy-injection annotation; no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-92811, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[djoshy]

/jira refresh

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-92811, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@djoshy: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.