Update boilerplate#240
Open
abyrne55 wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (3)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughUpdates build and runtime base images, enables codecov status thresholds, adds a repository pre-commit configuration with multiple hooks, and removes a GitHub alias entry from OWNERS_ALIASES. ChangesBuild and CI Configuration
Development Workflow and Team Management
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 9 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.pre-commit-config.yaml:
- Around line 123-134: The hook named "rbac-wildcard-check" currently runs the
command specified in entry ("make rbac-wildcard-check") which will cause
pre-commit to fail on non-zero exit, so either update the comment to state that
this hook is blocking (remove "warn-only") or change the hook to be non-blocking
by altering the entry to swallow failures (e.g., keep "entry" referencing the
same make target but ensure it returns success by appending a no-fail wrapper
around "make rbac-wildcard-check"); reference the id "rbac-wildcard-check" and
the entry command "make rbac-wildcard-check" when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8f6f365c-1975-43fb-a152-7c6723f9c138
⛔ Files ignored due to path filters (8)
boilerplate/_data/backing-image-tagis excluded by!boilerplate/**boilerplate/_data/last-boilerplate-commitis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/.codecov.ymlis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/OWNERS_ALIASESis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/golangci.ymlis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/pre-commit-config.yamlis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/standard.mkis excluded by!boilerplate/**boilerplate/openshift/golang-osd-operator/updateis excluded by!boilerplate/**
📒 Files selected for processing (6)
.ci-operator.yaml.codecov.yml.pre-commit-config.yamlOWNERS_ALIASESbuild/Dockerfilebuild/Dockerfile.olm-registry
💤 Files with no reviewable changes (1)
- OWNERS_ALIASES
Comment on lines
+123
to
+134
| # 6. RBAC WILDCARD CHECK | target < 5s | warn-only (blocking after cleanup) | ||
| # Rejects wildcard RBAC in deploy/ manifests (verbs/resources: ["*"] | ||
| # or multi-line - '*' format). Logic lives in standard.mk target | ||
| # 'rbac-wildcard-check' for readability and reuse. | ||
| # Fix: replace wildcards with explicit verbs and resource names. | ||
| # ----------------------------------------------------------------------- | ||
| - id: rbac-wildcard-check | ||
| name: RBAC wildcard permissions | ||
| language: system | ||
| entry: bash -c 'make rbac-wildcard-check' | ||
| files: ^deploy/.*\.ya?ml$ | ||
| pass_filenames: false |
There was a problem hiding this comment.
rbac-wildcard-check is blocking despite “warn-only” label.
The current hook will fail commits on non-zero exit, so it is not warn-only as described. Please align the comment (or the hook behavior) to avoid confusion.
Suggested minimal fix (docs aligned to actual behavior)
- # 6. RBAC WILDCARD CHECK | target < 5s | warn-only (blocking after cleanup)
+ # 6. RBAC WILDCARD CHECK | target < 5s | blocking📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # 6. RBAC WILDCARD CHECK | target < 5s | warn-only (blocking after cleanup) | |
| # Rejects wildcard RBAC in deploy/ manifests (verbs/resources: ["*"] | |
| # or multi-line - '*' format). Logic lives in standard.mk target | |
| # 'rbac-wildcard-check' for readability and reuse. | |
| # Fix: replace wildcards with explicit verbs and resource names. | |
| # ----------------------------------------------------------------------- | |
| - id: rbac-wildcard-check | |
| name: RBAC wildcard permissions | |
| language: system | |
| entry: bash -c 'make rbac-wildcard-check' | |
| files: ^deploy/.*\.ya?ml$ | |
| pass_filenames: false | |
| # 6. RBAC WILDCARD CHECK | target < 5s | blocking | |
| # Rejects wildcard RBAC in deploy/ manifests (verbs/resources: ["*"] | |
| # or multi-line - '*' format). Logic lives in standard.mk target | |
| # 'rbac-wildcard-check' for readability and reuse. | |
| # Fix: replace wildcards with explicit verbs and resource names. | |
| # ----------------------------------------------------------------------- | |
| - id: rbac-wildcard-check | |
| name: RBAC wildcard permissions | |
| language: system | |
| entry: bash -c 'make rbac-wildcard-check' | |
| files: ^deploy/.*\.ya?ml$ | |
| pass_filenames: false |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.pre-commit-config.yaml around lines 123 - 134, The hook named
"rbac-wildcard-check" currently runs the command specified in entry ("make
rbac-wildcard-check") which will cause pre-commit to fail on non-zero exit, so
either update the comment to state that this hook is blocking (remove
"warn-only") or change the hook to be non-blocking by altering the entry to
swallow failures (e.g., keep "entry" referencing the same make target but ensure
it returns success by appending a no-fail wrapper around "make
rbac-wildcard-check"); reference the id "rbac-wildcard-check" and the entry
command "make rbac-wildcard-check" when making the change.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abyrne55 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #240 +/- ##
=======================================
Coverage 58.60% 58.60%
=======================================
Files 5 5
Lines 244 244
=======================================
Hits 143 143
Misses 87 87
Partials 14 14 🚀 New features to boost your workflow:
|
abyrne55
force-pushed
the
update-boilerplate
branch
from
1b26f77 to
3752706
Compare
Contributor
|
@abyrne55: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync with latest boilerplate (61dbfdf)
Summary by CodeRabbit