Skip to content

[release-5.0] NO-ISSUE: Use --wait=false for namespace deletion in RF teardowns - #7307

Closed
agullon wants to merge 1 commit into
openshift:release-5.0from
agullon:NO-ISSUE-ns-wait-false-release-5.0
Closed

[release-5.0] NO-ISSUE: Use --wait=false for namespace deletion in RF teardowns#7307
agullon wants to merge 1 commit into
openshift:release-5.0from
agullon:NO-ISSUE-ns-wait-false-release-5.0

Conversation

@agullon

@agullon agullon commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

Backport of #7305 to release-5.0.

  • Use --wait=false in the Remove Namespace RF keyword so oc delete namespace returns immediately instead of blocking until all finalizers are processed.

Root cause: On ARM with dual-stack, OVN reconciliation after a network config change (dual-stack → single-stack) saturates the CPU. When suite teardown fires oc delete namespace during this window, the namespace garbage collection — competing with OVN for CPU — exceeds the 5-minute RF process timeout in Run With Kubeconfig. The killed oc process returns rc=1, the Should Be Equal As Integers assertion fails, and all passing tests are retroactively marked as suite teardown failures.

Fix: --wait=false marks the namespace for deletion and returns immediately. The API server continues cleanup asynchronously. This is safe because:

  • All 13 callers of Remove Namespace use it in teardown contexts where no subsequent test depends on the namespace being fully gone
  • Test VMs are torn down after the suite completes, so any in-progress namespace deletion is irrelevant

Observed in: e2e-aws-tests-bootc-release-arm-el9, scenario el98-lrel@dual-stack-configuration1 — all 4 dual-stack tests passed but were retroactively marked failed due to suite teardown timeout.

Test plan

  • Verify no caller of Remove Namespace depends on synchronous namespace deletion
  • Confirm dual-stack suite teardown completes without timeout on ARM

🤖 Generated with Claude Code

The Remove Namespace keyword runs `oc delete namespace` during suite
teardowns, blocking until all resources and finalizers are processed.
On ARM with dual-stack, OVN reconciliation after a network config
change saturates the CPU, causing namespace garbage collection to
exceed the 5-minute RF process timeout. The killed `oc` returns rc=1,
which cascades as a suite teardown failure and retroactively marks
all passing tests as failed.

Using --wait=false marks the namespace for deletion and returns
immediately. The API server cleans up asynchronously, which is safe
because test VMs are torn down after the suite completes.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

pre-commit.check-secrets: ENABLED
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 2, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@agullon: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

Backport of #7305 to release-5.0.

  • Use --wait=false in the Remove Namespace RF keyword so oc delete namespace returns immediately instead of blocking until all finalizers are processed.

Root cause: On ARM with dual-stack, OVN reconciliation after a network config change (dual-stack → single-stack) saturates the CPU. When suite teardown fires oc delete namespace during this window, the namespace garbage collection — competing with OVN for CPU — exceeds the 5-minute RF process timeout in Run With Kubeconfig. The killed oc process returns rc=1, the Should Be Equal As Integers assertion fails, and all passing tests are retroactively marked as suite teardown failures.

Fix: --wait=false marks the namespace for deletion and returns immediately. The API server continues cleanup asynchronously. This is safe because:

  • All 13 callers of Remove Namespace use it in teardown contexts where no subsequent test depends on the namespace being fully gone
  • Test VMs are torn down after the suite completes, so any in-progress namespace deletion is irrelevant

Observed in: e2e-aws-tests-bootc-release-arm-el9, scenario el98-lrel@dual-stack-configuration1 — all 4 dual-stack tests passed but were retroactively marked failed due to suite teardown timeout.

Test plan

  • Verify no caller of Remove Namespace depends on synchronous namespace deletion
  • Confirm dual-stack suite teardown completes without timeout on ARM

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 62371fd1-1203-43a6-a83c-a2e821761818

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jerpeter1 and pmtk September 2, 2026 10:48
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 2, 2026
@openshift-ci

openshift-ci Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agullon

agullon commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Consolidated into #7327

@agullon agullon closed this Sep 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants