NO-JIRA: duplicate dashboard creates perses project

[PeterYurkovich]

Summary by CodeRabbit

• Bug Fixes
  • Improved dashboard duplication by ensuring the required project is available before proceeding.
  • Duplicate actions now stop when project creation fails.
  • The duplicate button is disabled and displays a loading state while project creation is in progress.

[openshift-ci]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@PeterYurkovich: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1ab2e35e-f352-4579-be94-486e86273d6c

📥 Commits

Reviewing files that changed from the base of the PR and between 4528a6c and c5cf013.

📒 Files selected for processing (1)

• web/src/features/perses-dashboards/components/DashboardActionModals.tsx

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The duplicate dashboard modal now uses centralized project creation handling. It stops duplication when project creation fails and disables the duplicate button while project creation is in progress.

Changes

Dashboard duplication

Layer / File(s)	Summary
Project creation flow web/src/features/perses-dashboards/components/DashboardActionModals.tsx	The modal replaces inline project creation with ensureProjectExists. Failed project creation stops form submission. The duplicate button reflects the project creation loading state. Unused mutation handling is removed.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to c5cf0

The centralized project-creation flow preserves dashboard duplication behavior and no merge-blocking issue remains.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: duplicate dashboard creation now creates a Perses project.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS: The pull request changes only DashboardActionModals.tsx. The diff adds no Ginkgo test declarations or test titles, and the changed file contains no It(), Describe(), Context(), or `When(…
Test Structure And Quality	✅ Passed	PASS: The pull request changes only DashboardActionModals.tsx (TypeScript/TSX), with no Ginkgo test files or test constructs. Therefore, the listed Ginkgo test-quality requirements are not applicabl…
Microshift Test Compatibility	✅ Passed	PASS: The reviewed range changes only web/src/features/perses-dashboards/components/DashboardActionModals.tsx (+11/-25). It adds no Ginkgo e2e tests or other test files, so the MicroShift Test Compa…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only one frontend TypeScript file, DashboardActionModals.tsx. The diff adds no Ginkgo tests or It, Describe, Context, or When constructs. Therefore, the SNO mu…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only web/src/features/perses-dashboards/components/DashboardActionModals.tsx. The change updates dashboard duplication and project-creation UI logic. It adds no deploy…
Ote Binary Stdout Contract	✅ Passed	PASS. The authoritative pull-request range changes only web/src/features/perses-dashboards/components/DashboardActionModals.tsx, a React TypeScript component. The patch contains no main, `TestMain…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes one TypeScript component only. The authoritative diff adds no Ginkgo tests or test constructs such as It(), Describe(), Context(), or When(). It adds no IPv4 assumptions…
No-Weak-Crypto	✅ Passed	The pull request changes only DashboardActionModals.tsx and replaces project-creation flow logic. The added lines contain no MD5, SHA1, DES, 3DES, RC4, Blowfish, or ECB usage, custom cryptography, o…
Container-Privileges	✅ Passed	PASS. The pull request changes only DashboardActionModals.tsx, an application source file. The authoritative diff contains no container or Kubernetes manifest changes and no added privilege-related …
No-Sensitive-Data-In-Logs	✅ Passed	No sensitive-data logging was introduced. The pull request changes only DashboardActionModals.tsx; the diff adds no console, logger, telemetry, or error-reporting calls. It delegates project creat…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jgbernalp]

/test okd-scos-images

[jgbernalp]

/lgtm

[openshift-ci]

Scheduling required tests:
/test e2e-agnostic-cmo
/test e2e-monitoring

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• web/src/features/perses-dashboards/OWNERS [PeterYurkovich,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@PeterYurkovich: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jgbernalp]

/label qe-approved

[PeterYurkovich]

/remove qe-approved

[etmurasaki]

/remove-label qe-approved

[etmurasaki]

/remove label qe-approved

[etmurasaki]

/label qe-approved