Skip to content

[release-coo-1.5-ocp-4.15] NO-JIRA: Sanitize alert runbook URLs #1270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Sep 15, 2026
+36 −21
Merged

[release-coo-1.5-ocp-4.15] NO-JIRA: Sanitize alert runbook URLs #1270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
caa9add
OU-1488: sanitize alert runbook URLs
dchromik Sep 15, 2026
ccb9a78
OU-1488: move URL validation into ExternalLink
dchromik Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 36 additions & 21 deletions web/src/components/console/utils/link.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,27 +10,33 @@ export const ExternalLink: React.FC<ExternalLinkProps> = ({
additionalClassName = '',
dataTestID,
stopPropagation,
}) => (
<Button
variant="link"
component="a"
icon={
<Icon size="sm">
<ExternalLinkAltIcon />
</Icon>
}
className={additionalClassName}
href={href}
target="_blank"
iconPosition="end"
rel="noopener noreferrer"
data-test-id={dataTestID}
{...(stopPropagation ? { onClick: (e) => e.stopPropagation() } : {})}
isInline
>
{children || text}
</Button>
);
}) => {
if (!isSafeExternalURL(href)) {
return <>{children || text}</>;
}

return (
<Button
variant="link"
component="a"
icon={
<Icon size="sm">
<ExternalLinkAltIcon />
</Icon>
}
className={additionalClassName}
href={href}
target="_blank"
iconPosition="end"
rel="noopener noreferrer"
data-test-id={dataTestID}
{...(stopPropagation ? { onClick: (e) => e.stopPropagation() } : {})}
isInline
>
{children || text}
</Button>
);
};

// Open links in a new window and set noopener/noreferrer.
export const LinkifyExternal: React.FC<{ children: React.ReactNode }> = ({ children }) => (
Expand All @@ -45,3 +51,12 @@ type ExternalLinkProps = {
dataTestID?: string;
stopPropagation?: boolean;
};

const isSafeExternalURL = (value: string): value is string => {
if (!URL.canParse(value)) {
return false;
}

const { protocol } = new URL(value);
return protocol === 'http:' || protocol === 'https:';
};