Skip to content

OU-1203: upgrade perses dependencies#914

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jgbernalp:upgrade-perses-dependencies
May 6, 2026
Merged

OU-1203: upgrade perses dependencies#914
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
jgbernalp:upgrade-perses-dependencies

Conversation

@jgbernalp
Copy link
Copy Markdown
Contributor

@jgbernalp jgbernalp commented May 5, 2026

Upgrade perses dependencies to use the prometheus tenancy path

Summary by CodeRabbit

  • Chores
    • Updated UI and plugin packages to newer releases and adjusted core package version.
    • Pinned console dynamic plugin SDK to a specific prerelease for consistent behavior.
  • New Features
    • Improved dashboard panel focus handling for a smoother editing and navigation experience.
  • Chores
    • Minor internal cleanup in the dashboard editing flow with no visible changes.

@jgbernalp jgbernalp requested review from PeterYurkovich and zhuje May 5, 2026 11:47
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 5, 2026

@jgbernalp: This pull request references OU-1203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Upgrade perses dependencies to use the prometheus tenancy path

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2026
@jgbernalp
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.19

@openshift-ci openshift-ci Bot requested a review from etmurasaki May 5, 2026 11:48
@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2026
@jgbernalp
Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.15

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.15 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: fd3bb6d1-8bf4-4804-b867-16fefff7f36b

📥 Commits

Reviewing files that changed from the base of the PR and between 0cf2c0d and 7f8d2ee.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • web/package.json
  • web/src/components/dashboards/perses/PersesWrapper.tsx
  • web/src/components/dashboards/perses/dashboard-app.tsx

Walkthrough

Updates to dependency versions in web/package.json (Perses packages bumped to 0.54.0-beta.1, @perses-dev/core changed to 0.53.0, and three @openshift-console/dynamic-plugin-sdk* packages pinned to 4.22.0-prerelease.2), a small typing/cast simplification in web/src/components/dashboards/perses/dashboard-app.tsx, and insertion of PanelFocusProvider wrapping providers in web/src/components/dashboards/perses/PersesWrapper.tsx.

Changes

Dependency pinning and Perses providers wiring

Layer / File(s) Summary
Package Manifest
web/package.json
Bump @perses-dev/components, @perses-dev/dashboards, @perses-dev/explore, @perses-dev/plugin-system from 0.53.10.54.0-beta.1. Change @perses-dev/core from 0.53.10.53.0. Pin @openshift-console/dynamic-plugin-sdk, @openshift-console/dynamic-plugin-sdk-internal, @openshift-console/dynamic-plugin-sdk-webpack from ^4.22.0-prerelease.24.22.0-prerelease.2.
Imports
web/src/components/dashboards/perses/PersesWrapper.tsx
Add PanelFocusProvider to named imports from @perses-dev/dashboards.
Provider wiring
web/src/components/dashboards/perses/PersesWrapper.tsx
Wrap DatasourceStoreProvider and DataQueriesProvider inside PersesPrometheusDatasourceWrapper with a new PanelFocusProvider insertion.
Type annotations / UI component
web/src/components/dashboards/perses/dashboard-app.tsx
Simplify casts: handleDiscardChanges now calls onDiscard(dashboard as DashboardResource) (removed double cast); onEditButtonClick sets originalDashboard to dashboard as DashboardResource. No behavioral changes.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'upgrade perses dependencies' clearly and directly summarizes the main change: updating perses-related dependency versions in web/package.json.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo tests. The check addresses Ginkgo test naming (It(), Describe(), etc.), but PR only has standard Go tests using testing.T. Check not applicable.
Test Structure And Quality ✅ Passed This PR does not modify any Ginkgo test code. The changes are limited to TypeScript component files and package.json dependency updates. The custom check is not applicable to this PR.
Microshift Test Compatibility ✅ Passed No Ginkgo e2e tests are added in this PR. Changes are limited to web UI component TypeScript/JavaScript modifications and dependency version updates. The custom check is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR contains no Ginkgo e2e tests. Changes are limited to TypeScript components and dependency updates. The SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PR contains only web frontend dependency updates and React component changes. No deployment manifests, operator code, controllers, or scheduling constraints modified.
Ote Binary Stdout Contract ✅ Passed OTE Binary Stdout Contract check is not applicable. PR only modifies frontend TypeScript/JavaScript code (package.json and React components), not Go test code that would interact with OTE binaries.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains no Ginkgo e2e tests. Changes are limited to web/package.json dependency updates and React/TypeScript component modifications for the Perses dashboard UI.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

  • Generate code and open pull requests
  • Plan features and break down work
  • Investigate incidents and troubleshoot customer tickets together
  • Automate recurring tasks and respond to alerts with triggers
  • Summarize progress and report instantly

Built for teams:

  • Shared memory across your entire org—no repeating context
  • Per-thread sandboxes to safely plan and execute work
  • Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/package.json`:
- Around line 76-80: Update the root dependency declaration for
"@perses-dev/core" in package.json from "0.53.1" to "0.53.0" to align with the
peerDependency expected by the `@perses-dev` packages (e.g.
"@perses-dev/components", "@perses-dev/dashboards", "@perses-dev/explore",
"@perses-dev/plugin-system"); locate the "@perses-dev/core" entry in
package.json and change its version string to "0.53.0", then reinstall
dependencies to ensure a single shared copy is used.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4e4161ae-66ec-4368-bc87-c7815f9ca97d

📥 Commits

Reviewing files that changed from the base of the PR and between fe90151 and bc04c2b.

⛔ Files ignored due to path filters (1)
  • web/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • web/package.json

Comment thread web/package.json
@etmurasaki
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2026
@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

2 similar comments
@zhuje
Copy link
Copy Markdown
Contributor

zhuje commented May 5, 2026

/retest

@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

@jgbernalp jgbernalp force-pushed the upgrade-perses-dependencies branch from bc04c2b to 824b10b Compare May 5, 2026 13:17
@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels May 5, 2026
@etmurasaki
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 5, 2026
@jgbernalp jgbernalp force-pushed the upgrade-perses-dependencies branch from 824b10b to 0cf2c0d Compare May 5, 2026 17:33
Signed-off-by: Gabriel Bernal <gbernal@redhat.com>
@jgbernalp jgbernalp force-pushed the upgrade-perses-dependencies branch 2 times, most recently from 0cf2c0d to 7f8d2ee Compare May 6, 2026 13:08
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

@jgbernalp: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@etmurasaki
Copy link
Copy Markdown
Contributor

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label May 6, 2026
@etmurasaki
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [etmurasaki,jgbernalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 3327aad into openshift:main May 6, 2026
10 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: #914 failed to apply on top of branch "release-coo-ocp-4.19":

Applying: upgrade perses dependencies
Using index info to reconstruct a base tree...
M	web/package-lock.json
M	web/package.json
M	web/src/components/dashboards/perses/PersesWrapper.tsx
M	web/src/components/dashboards/perses/dashboard-app.tsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/components/dashboards/perses/dashboard-app.tsx
Auto-merging web/src/components/dashboards/perses/PersesWrapper.tsx
Auto-merging web/package.json
CONFLICT (content): Merge conflict in web/package.json
Auto-merging web/package-lock.json
CONFLICT (content): Merge conflict in web/package-lock.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 upgrade perses dependencies

Details

In response to this:

/cherry-pick release-coo-ocp-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@jgbernalp: #914 failed to apply on top of branch "release-coo-ocp-4.15":

Applying: upgrade perses dependencies
Using index info to reconstruct a base tree...
M	web/package-lock.json
M	web/package.json
M	web/src/components/dashboards/perses/PersesWrapper.tsx
M	web/src/components/dashboards/perses/dashboard-app.tsx
Falling back to patching base and 3-way merge...
Auto-merging web/src/components/dashboards/perses/dashboard-app.tsx
Auto-merging web/src/components/dashboards/perses/PersesWrapper.tsx
Auto-merging web/package.json
CONFLICT (content): Merge conflict in web/package.json
Auto-merging web/package-lock.json
CONFLICT (content): Merge conflict in web/package-lock.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 upgrade perses dependencies

Details

In response to this:

/cherry-pick release-coo-ocp-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@zhuje
Copy link
Copy Markdown
Contributor

zhuje commented May 7, 2026

/cherry-pick release-coo-ocp-4.22

@openshift-cherrypick-robot
Copy link
Copy Markdown

@zhuje: new pull request created: #918

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants