Skip to content

OCPBUGS-87371: Updating nmstate-console-plugin-container image to be consistent with ART for 5.0 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openshift-bot wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

OCPBUGS-87371: Updating nmstate-console-plugin-container image to be consistent with ART for 5.0 #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci-operator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
build_root_image:
name: release
namespace: openshift
tag: rhel-9-release-golang-1.25-openshift-4.22
tag: rhel-9-release-golang-1.26-openshift-5.0
4 changes: 2 additions & 2 deletions Dockerfile.art
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Builder container
FROM registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-4.22 AS build
FROM registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-5.0 AS build

@coderabbitai coderabbitai Bot Jun 6, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Use supported Red Hat catalog base images instead of CI registry images.

Both updated FROM references still point to registry.ci.openshift.org/..., which violates the container base-image policy for Dockerfiles. Please switch these to approved images from catalog.redhat.com (while keeping floating tags for RH images).
As per coding guidelines, "**/{Dockerfile,Containerfile}*: Base image: UBI minimal or distroless from catalog.redhat.com."

Suggested direction 
-FROM registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-5.0 AS build
+FROM <catalog.redhat.com-approved-builder-image>:<floating-tag> AS build
...
-FROM registry.ci.openshift.org/ocp/5.0:base-rhel9
+FROM <catalog.redhat.com-approved-runtime-image>:<floating-tag>

Also applies to: 14-14

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile.art` at line 2, Change the base image reference in the FROM line
that currently uses registry.ci.openshift.org (the "FROM
registry.ci.openshift.org/ocp/builder:rhel-9-base-nodejs-openshift-5.0 AS build"
entry) to an approved Red Hat catalog image from catalog.redhat.com (use the UBI
minimal or distroless variant appropriate for NodeJS), keeping a floating tag
style (no immutable digest) and equivalent platform (e.g., UBI9 NodeJS image),
so the Dockerfile uses a supported catalog.redhat.com base image instead of the
CI registry.

Source: Coding guidelines

ENV CYPRESS_INSTALL_BINARY 0

# Copy app source
Expand All @@ -11,7 +11,7 @@ USER 0
RUN npm ci && npm run build

# Web server container
FROM registry.ci.openshift.org/ocp/4.22:base-rhel9
FROM registry.ci.openshift.org/ocp/5.0:base-rhel9

RUN INSTALL_PKGS="nginx" && \
dnf install -y --setopt=tsflags=nodocs $INSTALL_PKGS && \
Expand Down