[oadp-1.4] Add --ginkgo.junit-report flag to test-e2e target - #2411
Conversation
oadp-1.4's test-e2e never wrote junit_report.xml to $ARTIFACT_DIR, unlike oadp-1.5/oadp-dev which already pass this flag. Any tooling expecting JUnit results in Prow artifacts for oadp-1.4 (including the new oadp-analyze-e2e-failure CI post-step) was missing that input. Fixes openshift#2410 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit ceb152b to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## oadp-1.4 #2411 +/- ##
=========================================
Coverage 39.37% 39.37%
=========================================
Files 30 30
Lines 5211 5211
=========================================
Hits 2052 2052
Misses 2959 2959
Partials 200 200 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar, sseago The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
oadp-1.4'stest-e2etarget was missing the--ginkgo.junit-reportflag present onoadp-1.5/oadp-dev, so it never wrotejunit_report.xmlto$ARTIFACT_DIR. Unrelated to the Claude CLI hook removed in #2408/#2409 —oadp-1.4never had that hook; this is just an olderMakefilepredating the flag.Adds
--ginkgo.junit-report="$(ARTIFACT_DIR)/junit_report.xml"to match the other branches.Fixes #2410
Note
Responses generated with Claude