Skip to content

[oadp-1.4] Add --ginkgo.junit-report flag to test-e2e target - #2411

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-1.4from
kaovilai:issue-2410-oadp-1.4-junit-report
Aug 25, 2026
Merged

[oadp-1.4] Add --ginkgo.junit-report flag to test-e2e target#2411
openshift-merge-bot[bot] merged 1 commit into
openshift:oadp-1.4from
kaovilai:issue-2410-oadp-1.4-junit-report

Conversation

@kaovilai

Copy link
Copy Markdown
Member

Summary

oadp-1.4's test-e2e target was missing the --ginkgo.junit-report flag present on oadp-1.5/oadp-dev, so it never wrote junit_report.xml to $ARTIFACT_DIR. Unrelated to the Claude CLI hook removed in #2408/#2409oadp-1.4 never had that hook; this is just an older Makefile predating the flag.

Adds --ginkgo.junit-report="$(ARTIFACT_DIR)/junit_report.xml" to match the other branches.

Fixes #2410

Note

Responses generated with Claude

oadp-1.4's test-e2e never wrote junit_report.xml to $ARTIFACT_DIR,
unlike oadp-1.5/oadp-dev which already pass this flag. Any tooling
expecting JUnit results in Prow artifacts for oadp-1.4 (including the
new oadp-analyze-e2e-failure CI post-step) was missing that input.

Fixes openshift#2410

Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 2f39382a-8e85-47a2-960c-c00eedbfa010

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.37%. Comparing base (a5a8583) to head (914cdfe).

⚠️ Current head 914cdfe differs from pull request most recent head ceb152b

Please upload reports for the commit ceb152b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff            @@
##           oadp-1.4    #2411   +/-   ##
=========================================
  Coverage     39.37%   39.37%           
=========================================
  Files            30       30           
  Lines          5211     5211           
=========================================
  Hits           2052     2052           
  Misses         2959     2959           
  Partials        200      200           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shubham-pampattiwar shubham-pampattiwar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2026
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [Joeavaikath,kaovilai,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot
openshift-merge-bot Bot merged commit 431ca46 into openshift:oadp-1.4 Aug 25, 2026
11 checks passed
@kaovilai kaovilai linked an issue Aug 25, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

oadp-1.4: test-e2e Makefile target doesn't generate junit_report.xml

5 participants