Skip to content

NO-JIRA: Replace a bug id: 25739 -> 92835#31345

Open
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:OCPBUGS-92835-sub-OCPBUGS-OCPBUGS-25739
Open

NO-JIRA: Replace a bug id: 25739 -> 92835#31345
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:OCPBUGS-92835-sub-OCPBUGS-OCPBUGS-25739

Conversation

@hongkailiu

@hongkailiu hongkailiu commented Jun 26, 2026

Copy link
Copy Markdown
Member

The old one is closed but the symptom is still there. It is tracked it by a new bug.

Moreover, the symptom Available=False extends

  • from bare-metal to Hypershift
  • from upgrade to non-upgrade tests

/cc @mkowalski @candita

Summary by CodeRabbit

  • Bug Fixes
    • Updated monitoring to recognize a known acceptable ingress availability transition when the component reports unavailable.
    • Adjusted the reported issue reference for this condition during upgrades, aligning it with the current tracked behavior.

The old one is closed but the symptom is still there.
It is tracked by a new bug.

Moreover, the symptom `Available=False` extends
* from bare-metal to Hypershift
* from upgrade to non-upgrade tests
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@hongkailiu: This pull request explicitly references no jira issue.

Details

In response to this:

The old one is closed but the symptom is still there. It is tracked it by a new bug.

Moreover, the symptom Available=False extends

  • from bare-metal to Hypershift
  • from upgrade to non-upgrade tests

/cc @mkowalski @candita

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from candita and mkowalski June 26, 2026 14:38
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hongkailiu hongkailiu marked this pull request as ready for review June 26, 2026 14:38
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c8a7c63d-ae0a-427d-b92f-a2a9f61b6f47

📥 Commits

Reviewing files that changed from the base of the PR and between 817fa8a and 1d98e87.

📒 Files selected for processing (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Walkthrough

The PR updates legacy CVO monitor test exceptions so ingress operator Available=False with IngressUnavailable maps to OCPBUGS-92835 in stable-system and upgrade checks.

Changes

Ingress exception mapping

Layer / File(s) Summary
IngressUnavailable mapping
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
Stable-system and upgrade operator state transition checks now map ingress Available=False with reason IngressUnavailable to OCPBUGS-92835.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: replacing the old bug reference with OCPBUGS-92835.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only updates ingress exception bug refs; no It/Describe/Context/When titles were added or changed, and the package uses plain Go test funcs.
Test Structure And Quality ✅ Passed The change only updates ingress exception callbacks in helper code; no Ginkgo specs, cluster setup, or Eventually/Consistently calls were added or altered.
Microshift Test Compatibility ✅ Passed The PR only changes operator-state exception callbacks in a monitor helper; operators.go has no Ginkgo test defs or MicroShift-unsupported test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; this commit only updates ingress exception mappings in helper functions, so the SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only test exception mappings changed in operators.go; no manifests, controllers, or scheduling constraints were added or modified.
Ote Binary Stdout Contract ✅ Passed PR only updates ingress bug references in test helper logic; no main/init/suite setup or stdout writes are added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Touched code only updates ingress exception bug links in helper callbacks; no new Ginkgo blocks, IPv4 assumptions, or external connectivity.
No-Weak-Crypto ✅ Passed Only bug-reference strings changed for ingress exceptions; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear.
Container-Privileges ✅ Passed PR only edits a Go test exception callback; no container/K8s manifests were changed and no privileged/hostNetwork/allowPrivilegeEscalation settings appear in the touched file.
No-Sensitive-Data-In-Logs ✅ Passed The PR only changes the ingress exception bug reference; no new logging or sensitive-data handling was added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign neisw for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@hongkailiu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-csi 1d98e87 link true /test e2e-gcp-csi
ci/prow/e2e-vsphere-ovn-upi 1d98e87 link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn 1d98e87 link true /test e2e-vsphere-ovn
ci/prow/e2e-aws-ovn-fips 1d98e87 link true /test e2e-aws-ovn-fips
ci/prow/e2e-metal-ipi-ovn-ipv6 1d98e87 link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants