Skip to content

Remove exception for OCPBUGS-45921#31346

Open
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:rm-OCPBUGS-45921
Open

Remove exception for OCPBUGS-45921#31346
hongkailiu wants to merge 1 commit into
openshift:mainfrom
hongkailiu:rm-OCPBUGS-45921

Conversation

@hongkailiu

@hongkailiu hongkailiu commented Jun 26, 2026

Copy link
Copy Markdown
Member

The bug is fixed on both 4.22 and 5.0 [1].

[1]. https://redhat.atlassian.net/browse/OCPBUGS-45921?focusedCommentId=17383073

Summary by CodeRabbit

  • Bug Fixes
    • Removed a stale exception for the ingress operator during stable-system availability checks.
    • This keeps operator status handling aligned with the current behavior and avoids showing an outdated special-case message.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@hongkailiu hongkailiu marked this pull request as ready for review June 26, 2026 15:01
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2026
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: f4aad7d5-1ef4-4e6c-9baa-9da18ee03c05

📥 Commits

Reviewing files that changed from the base of the PR and between 817fa8a and 8061da4.

📒 Files selected for processing (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
💤 Files with no reviewable changes (1)
  • pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go

Walkthrough

The stable-system operator transition test no longer accepts the ingress-specific exception mapping.

Changes

Stable-system operator exception change

Layer / File(s) Summary
Remove ingress exception
pkg/monitortests/clusterversionoperator/legacycvomonitortests/operators.go
The testStableSystemOperatorStateTransitions exception callback no longer includes the ingress operator branch.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the OCPBUGS-45921 exception.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The PR only removes an exception mapping; no Ginkgo It/Describe/Context/When titles were added or changed, and existing JUnit names are static templates.
Test Structure And Quality ✅ Passed Not applicable: the PR only removes one exception mapping in a helper; no Ginkgo specs, setup/cleanup, waits, or assertions were added or changed.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e test was added; this change only removes an exception in monitor-test logic and doesn’t add MicroShift-incompatible coverage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The PR only removes an exception in a monitor-test helper; it adds no Ginkgo It/Describe/Context/When blocks or new multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed Only a monitor test exception mapping changed; no deployment, controller, or scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed Changed package has no main/TestMain/suite setup or stdout writes; the modified file is a helper test function only.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Touched helper adds no Ginkgo tests; no It/Describe/Context/When or IPv4/public-network literals found, so the IPv6/disconnected check isn’t triggered.
No-Weak-Crypto ✅ Passed The touched test file only removes an operator exception mapping; no weak-crypto APIs, algorithms, or secret comparisons appear in the diff or file.
Container-Privileges ✅ Passed PASS: The PR only edits pkg/monitortests/.../operators.go test logic; no manifests or privileged/hostNetwork/allowPrivilegeEscalation fields were added or changed.
No-Sensitive-Data-In-Logs ✅ Passed PR only removes an ingress exception mapping; no new logging or sensitive-data-bearing fields were added in the touched code.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from p0lyn0mial and sjenning June 26, 2026 15:01
@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Jun 26, 2026
@hongkailiu

Copy link
Copy Markdown
Member Author

/cc @candita

@openshift-ci openshift-ci Bot requested a review from candita June 26, 2026 15:03
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@candita

candita commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Looks like an install failure, so retesting:
/test e2e-gcp-csi

@candita

candita commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

/assign

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

@hongkailiu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-fips 8061da4 link true /test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@candita

candita commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2026
@openshift-ci

openshift-ci Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: candita, hongkailiu
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants