OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22#31349
Conversation
…parsing Bumps github.com/openshift-eng/openshift-tests-extension from v0.0.0-20260127124016-0fed2b824818 to v0.0.0-20260626105913-1f81f3df939a. This includes the fix from OTE PR openshift#74 which makes the JSON parser in openshift-tests-extension tolerate klog noise on stdout when listing OTE binary tests (e.g. cloud-controller-manager-aws-tests-ext). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/retitle [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 |
|
/assign |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 |
|
@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/638ed9c0-73e4-11f1-9d4e-3d9df9f59fc0-0 |
|
/retitle [openshift-4.22] OCPBUGS-92656: bump openshift-tests-extension to fix klog stdout parsing on 4.22 |
|
/assign |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4 |
|
@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ae693a0-73f0-11f1-897c-e6569c90f50b-0 |
|
/payload-job-with-prs periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4 openshift/cluster-cloud-controller-manager-operator#482 |
|
@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e18cf420-73fc-11f1-9177-1dfff53c3a1a-0 |
…x klog stdout parsing Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv4 |
|
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-metal-ipi-ovn-ipv6 |
|
@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50e06020-7400-11f1-8653-7e56b9c2b530-0 |
|
@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/50ae53a0-7400-11f1-92b9-d3a7d5befa84-0 |
|
/lgtm |
|
@stbenjam: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: redhat-chai-bot, stbenjam The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I dunno why the jira bot is MIA, but the bug looks correct. |
|
@redhat-chai-bot: Jira Issue OCPBUGS-92656 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@tthvo: Jira Issue Verification Checks: Jira Issue OCPBUGS-92656 Jira Issue OCPBUGS-92656 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Fix included in release 4.22.0-0.nightly-2026-06-30-192322 |
Summary
Bumps
github.com/openshift-eng/openshift-tests-extensionfromv0.0.0-20260127124016-0fed2b824818tov0.0.0-20260626105913-1f81f3df939ato pick up OTE PR #74.Problem
PR openshift/cluster-cloud-controller-manager-operator#480 added dualstack test support to the CCM AWS OTE binary. This introduced a
framework.LoadConfig()call that initializesklog, which writes INFO lines to stdout. Whenopenshift-testsruns the binary'slistsubcommand, it expects pure JSON on stdout but gets klog noise — causinginvalid character 'I' looking for beginning of valueerrors.This breaks metal platform nightly jobs (
metal-ipi-ovn-ipv4,metal-ipi-ovn-ipv6) because the OTE binary is extracted and listed on all platforms.Fix
OTE PR #74 updated
openshift-tests-extensionto scan for the first{or[line before unmarshalling JSON, tolerating stdout contamination from klog or other sources. This bump brings that fix to the 4.22 branch ofopenshift-tests, fixing the issue for all OTE binaries — not just CCM.Testing
After merging, metal nightly jobs should pass again. The CCM fix-forward PR (openshift/cluster-cloud-controller-manager-operator#482) can be re-tested with
/payload-jobformetal-ipi-ovn-ipv4andmetal-ipi-ovn-ipv6.