OCPQUAL-20: Refresh retry allowlist against 5.0 and 5.1 CI data

[mkowalski]

What

Refreshes pkg/test/ginkgo/retry_allowed_tests.yaml against current CI retry
statistics (last 30 days, >= 5 flakes threshold).

• Removes 26 tests that no longer meet the flake threshold in either 5.0 or
  5.1 CI, leaving 97 tests (down from 123).
• Removals only — no tests are added.
• Since origin/main now targets 5.1, the documented candidate query is
  widened to variant_value IN ('5.0', '5.1'). A test keeps its retry
  eligibility if it still flakes >= 5 times in either release, so tests still
  flaking on main (5.1) are not dropped even if they have gone quiet in 5.0.

Why

The allowlist is intended to shrink over time as flaky tests are fixed.
Regenerating from current data drops tests that no longer flake, so they must
pass on the first attempt again. Widening the candidate set to 5.0 + 5.1 avoids
removing retry eligibility from tests that are still flaking on the release
main now runs against. Newly qualifying tests are added only after review, not
automatically, so this refresh only ever removes entries.

---

This PR was generated using AI. Please verify before acting on it.

Summary by CodeRabbit

• Tests
  • Improved release validation for versions 5.0 and 5.1.
  • Updated retry coverage to better reflect current OAuth, CLI, developer experience, image registry, and build workflows.
  • Removed outdated and redundant test scenarios from retry validation.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[openshift-ci-robot]

@mkowalski: This pull request references OCPQUAL-20 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.1.0" version, but no target version was set.

Details

In response to this:

What

Refreshes pkg/test/ginkgo/retry_allowed_tests.yaml against current CI retry
statistics (last 30 days, >= 5 flakes threshold).

• Removes 26 tests that no longer meet the flake threshold in either 5.0 or
  5.1 CI, leaving 97 tests (down from 123).
• Removals only — no tests are added.
• Since origin/main now targets 5.1, the documented candidate query is
  widened to variant_value IN ('5.0', '5.1'). A test keeps its retry
  eligibility if it still flakes >= 5 times in either release, so tests still
  flaking on main (5.1) are not dropped even if they have gone quiet in 5.0.

Why

The allowlist is intended to shrink over time as flaky tests are fixed.
Regenerating from current data drops tests that no longer flake, so they must
pass on the first attempt again. Widening the candidate set to 5.0 + 5.1 avoids
removing retry eligibility from tests that are still flaking on the release
main now runs against. Newly qualifying tests are added only after review, not
automatically, so this refresh only ever removes entries.

---

This PR was generated using AI. Please verify before acting on it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: d237f9bd-d1b6-4652-80f2-5d78a69a2375

📥 Commits

Reviewing files that changed from the base of the PR and between ed9fd91 and 07fbea7.

📒 Files selected for processing (1)

• pkg/test/ginkgo/retry_allowed_tests.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

Walkthrough

The retry-eligible test list now uses a 5.0 and 5.1 candidate query. The list removes obsolete tests and adds or retains qualifying OAuth, CLI, DevEx, image-registry, and build candidates.

Changes

Retry-eligible test list

Layer / File(s)	Summary
Refresh policy and candidate query pkg/test/ginkgo/retry_allowed_tests.yaml	The documentation defines refresh and review rules. The candidate query now covers releases 5.0 and 5.1 over the previous 30 days with at least five flakes.
Retry candidate set pkg/test/ginkgo/retry_allowed_tests.yaml	The list removes obsolete CLI, template, image-policy, and Gateway API candidates. It retains or adds newer qualifying tests.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 07fbe

This PR refreshes the retry allowlist by removing tests that no longer meet the stated flake threshold; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the retry allowlist refresh and the 5.0 and 5.1 CI data used.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The diff changes only the retry allowlist and query comments, removes 26 existing entries, and adds no test titles or dynamic values.
Test Structure And Quality	✅ Passed	The commit changes only the retry allowlist YAML: 26 entries are removed and none added; no Ginkgo It blocks or test setup, waits, or assertions change.
Microshift Test Compatibility	✅ Passed	The diff changes only retry_allowed_tests.yaml: it removes 28 entries and updates a query comment; no new Ginkgo e2e tests are added.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only the retry allowlist YAML; it adds no Ginkgo test code or new It/Describe/Context/When blocks to assess for SNO assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only pkg/test/ginkgo/retry_allowed_tests.yaml; it adds no manifests, operator code, controllers, or scheduling constraints.
Ote Binary Stdout Contract	✅ Passed	The commit changes only retry_allowed_tests.yaml comments and test entries; it adds no process-level code or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only the retry allowlist YAML: 26 entries were removed and none were added; no new Ginkgo e2e tests or network behavior were introduced.
No-Weak-Crypto	✅ Passed	The PR changes only retry_allowed_tests.yaml; added lines contain query/comments only, and no weak-crypto or secret-comparison usage is introduced. Existing SHA1 code is unchanged.
Container-Privileges	✅ Passed	The diff changes only retry-list comments, a release query, and test-name entries; it adds no container/Kubernetes privilege fields or SYS_ADMIN capability.
No-Sensitive-Data-In-Logs	✅ Passed	The diff only removes 26 allowlist entries and updates a comment/query. It adds no logging or sensitive values; existing test-name debug logs are unchanged.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mkowalski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mkowalski]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mkowalski]

/cc @dgoodwin

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[openshift-ci]

@mkowalski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-fips	07fbea7	link	true	/test e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.