[release-5.0] OCPBUGS-113760: Allow KubeDaemonSetMisScheduled alert on external platform clusters

[redhat-chai-bot]

Cherry-pick of #31556 to release-5.0 (manual — cherry-pick bot failed due to merge conflict).

The release-5.0 branch uses []string + append for allowedAlertNames while main uses sets.Set + Insert. This cherry-pick adapts the fix to use the release-5.0 syntax.

Changes

• test/extended/util/framework.go: Added IsExternalPlatformCluster() helper that checks infrastructure.Status.PlatformStatus.Type == configv1.ExternalPlatformType
• test/extended/prometheus/prometheus.go: Extended the KubeDaemonSetMisScheduled alert allowance to include External platform clusters alongside managed-service clusters

Jira

• Backport bug: OCPBUGS-113760
• Original bug: OCPBUGS-112283
• Original PR: OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters #31556

---

AI-generated. Review for accuracy.

@mtulio requested in Slack thread

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a9473aa0-2704-4d3a-a014-58dd6547acb0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[mtulio]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f79bba40-a097-11f1-8e43-0938f582902d-0

[mtulio]

/retitle [release-5.0] OCPBUGS-113760: Allow KubeDaemonSetMisScheduled alert on external platform clusters

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-113760, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-113760 to depend on a bug targeting a version in 5.1.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Cherry-pick of #31556 to release-5.0 (manual — cherry-pick bot failed due to merge conflict).

The release-5.0 branch uses []string + append for allowedAlertNames while main uses sets.Set + Insert. This cherry-pick adapts the fix to use the release-5.0 syntax.

Changes

• test/extended/util/framework.go: Added IsExternalPlatformCluster() helper that checks infrastructure.Status.PlatformStatus.Type == configv1.ExternalPlatformType
• test/extended/prometheus/prometheus.go: Extended the KubeDaemonSetMisScheduled alert allowance to include External platform clusters alongside managed-service clusters

Jira

• Backport bug: OCPBUGS-113760
• Original bug: OCPBUGS-112283
• Original PR: OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters #31556

---

AI-generated. Review for accuracy.

@mtulio requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

/jira refresh

[openshift-ci-robot]

@mtulio: This pull request references Jira Issue OCPBUGS-113760, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-112283 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-112283 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

/ok-to-test

[mtulio]

/lgtm

[mtulio]

Waiting for payload job.
/hold

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

[mtulio]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e972ab40-a0bf-11f1-8628-934571265154-0

[mtulio]

previous job is getting quota issues, scheduling a new one.

[mtulio]

/payload-job periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

[openshift-ci]

@mtulio: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-5.0-opct-platform-external-aws

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5975b660-a0fe-11f1-95b7-826c75d0605c-0

[mtulio]

/lgtm
/approve
/assign @neisw
/hold cancel
/verified by CI payload job https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31558-nightly-5.0-opct-platform-external-aws/2092454375208259584. The test [sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Early][apigroup:config.openshift.io] [Suite:openshift/conformance/parallel] is still failing but not caused by KubeDaemonSetMisScheduled. We are going to file a bug reporting KubeDaemonSetRolloutStuck as well.

[openshift-ci-robot]

@mtulio: This PR has been marked as verified by CI payload job https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31558-nightly-5.0-opct-platform-external-aws/2092454375208259584. The test [sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Early][apigroup:config.openshift.io] [Suite:openshift/conformance/parallel]is still failing but not caused byKubeDaemonSetMisScheduled. We are going to file a bug reporting KubeDaemonSetRolloutStuck as well..

Details

In response to this:

/lgtm
/approve
/assign @neisw
/hold cancel
/verified by CI payload job https://prow.ci.openshift.org/view/gs/test-platform-results/logs/openshift-origin-31558-nightly-5.0-opct-platform-external-aws/2092454375208259584. The test [sig-instrumentation] Prometheus [apigroup:image.openshift.io] when installed on the cluster shouldn't report any alerts in firing state apart from Watchdog and AlertmanagerReceiversNotConfigured [Early][apigroup:config.openshift.io] [Suite:openshift/conformance/parallel] is still failing but not caused by KubeDaemonSetMisScheduled. We are going to file a bug reporting KubeDaemonSetRolloutStuck as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[mtulio]

/label backport-risk-assessed,

[openshift-ci]

@mtulio: The label(s) /label backport-risk-assessed, cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, verified, ready-for-human-review, reliability, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, ci/severity-critical, jira/skip-dependent-bug-check, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label backport-risk-assessed,

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mtulio]

/label backport-risk-assessed

[openshift-ci]

@mtulio: The label(s) backport-risk-assessed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: openshift-patch-managers, openshift-release-oversight, openshift-staff-engineers, openshift-sustaining-engineers

Details

In response to this:

/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[neisw]

/approve
/label backport-risk-assessed

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, neisw, redhat-chai-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [neisw]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[neisw]

/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial

[openshift-ci]

@neisw: Overrode contexts on behalf of neisw: ci/prow/e2e-aws-ovn-microshift, ci/prow/e2e-aws-ovn-microshift-serial

Details

In response to this:

/override ci/prow/e2e-aws-ovn-microshift
/override ci/prow/e2e-aws-ovn-microshift-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@redhat-chai-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-microshift	01e744d	link	true	/test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial	01e744d	link	true	/test e2e-aws-ovn-microshift-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@redhat-chai-bot: Jira Issue Verification Checks: Jira Issue OCPBUGS-113760
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-113760 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Cherry-pick of #31556 to release-5.0 (manual — cherry-pick bot failed due to merge conflict).

The release-5.0 branch uses []string + append for allowedAlertNames while main uses sets.Set + Insert. This cherry-pick adapts the fix to use the release-5.0 syntax.

Changes

• test/extended/util/framework.go: Added IsExternalPlatformCluster() helper that checks infrastructure.Status.PlatformStatus.Type == configv1.ExternalPlatformType
• test/extended/prometheus/prometheus.go: Extended the KubeDaemonSetMisScheduled alert allowance to include External platform clusters alongside managed-service clusters

Jira

• Backport bug: OCPBUGS-113760
• Original bug: OCPBUGS-112283
• Original PR: OCPBUGS-112283: Allow KubeDaemonSetMisScheduled alert on external platform clusters #31556

---

AI-generated. Review for accuracy.

@mtulio requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.