Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions ci-operator/config/trusted-execution-clusters/operator/OWNERS
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
reviewers:
- alicefr
- yalzhang
- Jakob-Naucke
- fangge1212
approvers:
- alicefr
- Jakob-Naucke
- fangge1212
- yalzhang
Original file line number Diff line number Diff line change
@@ -1,31 +1,74 @@
base_images:
telco-runner:
name: telco-runner
namespace: ci
tag: latest
cli:
name: "4.21"
namespace: ocp
tag: cli
build_root:
image_stream_tag:
name: builder
namespace: ocp
tag: rhel-9-golang-1.25-openshift-4.21
images:
items:
Comment on lines +11 to +12

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical | ⚡ Quick win

Invalid images schema structure.

The ci-operator images field must be a list directly under the key, not nested under items:. This structure will fail config validation.

🐛 Proposed fix
 images:
-  items:
   - dockerfile_literal: |

Remove the items: key and unindent all image entries by 2 spaces.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml`
around lines 11 - 12, The YAML currently nests the image list under the key
`items` (i.e., images: items:), which violates the ci-operator schema; remove
the `items:` key and unindent the image entries so `images:` directly contains a
YAML sequence (each image as `- name: ...` / `- from: ...` or simple `-
"registry/path:tag"` as used in this repo), ensuring the list items are direct
children of `images` rather than under `items`.

- dockerfile_literal: |
FROM src
COPY oc /usr/bin/oc
RUN dnf install -y gcc-c++ jq openssl-devel pkg-config && \
dnf clean all
from: src
inputs:
cli:
paths:
- destination_dir: .
source_path: /usr/bin/oc
to: kubevirt-test-image
- dockerfile_path: Containerfile
build_args:
- name: build_type
value: release
to: operator
- dockerfile_path: compute-pcrs/Containerfile
build_args:
- name: build_type
value: release
to: compute-pcrs
- dockerfile_path: register-server/Containerfile
build_args:
- name: build_type
value: release
to: register-server
- dockerfile_path: attestation-key-register/Containerfile
build_args:
- name: build_type
value: release
to: attestation-key-register
releases:
latest:
candidate:
architecture: amd64
product: ocp
stream: nightly
version: "4.21"
resources:
'*':
limits:
memory: 4Gi
memory: 8Gi
requests:
cpu: 100m
memory: 200Mi
tests:
- as: operator-lifecycle-verify
capabilities:
- intranet
skip_if_only_changed: ^(\.github|LICENSES|bundle|docs|examples)/|^(README\.md|\.gitignore)$
steps:
post:
- chain: trusted-execution-clusters-operator-cleanup
cluster_profile: azure-virtualization
env:
BASE_DOMAIN: cnv-devel.azure.devcluster.openshift.com
CNV_VERSION: "4.21"
COMPUTE_NODE_TYPE: Standard_D4s_v5
test:
- chain: trusted-execution-clusters-operator-infra-provision
- chain: trusted-execution-clusters-operator-lifecycle
- ref: interop-tests-deploy-cnv
- ref: trusted-execution-clusters-ref-operator-test
workflow: ipi-azure
zz_generated_metadata:
branch: main
org: trusted-execution-clusters
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
reviewers:
- alicefr
- yalzhang
- Jakob-Naucke
- fangge1212
approvers:
- alicefr
- Jakob-Naucke
- fangge1212
- yalzhang

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
reviewers:
- alicefr
- yalzhang
- Jakob-Naucke
- fangge1212
approvers:
- alicefr
- Jakob-Naucke
- fangge1212
- yalzhang

This file was deleted.

Loading