Added oauth annotations to gcsweb-private service account#80749
Added oauth annotations to gcsweb-private service account#80749hector-vido wants to merge 1 commit into
Conversation
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughTwo OAuth-related annotations are added to the Changesgcsweb-private OAuth Redirect Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hector-vido The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@hector-vido: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Some annotations used by oauth was missing from
gcsweb-privateservice account, without them we can't even insert our credentials, an error screen is returned immediately.The error was:
{"error": "server_error","error_description": "The authorization server encountered an unexpected condition that prevented it from fulfilling the request.","state": "a54de56e299bd70629af15c6657870b8:/gcs/origin-ci-private/pr-logs/pull/openshift-priv_cluster-etcd-operator/1/pull-ci-openshift-priv-cluster-etcd-operator-release-4.22-e2e-aws-ovn-single-node/2067426346849538048/"}Slack thread: https://redhat-internal.slack.com/archives/CBN38N3MW/p1781792228650009
Summary by CodeRabbit
This PR adds missing OAuth annotations to the
gcsweb-privateservice account in the OpenShift CI Prow cluster deployment. Thegcsweb-privateservice is part of the Prow infrastructure (specifically the Google Cloud Storage web service) that requires OAuth authentication.Two annotations were added to enable OAuth proxy integration:
gcsweb-privateRoute, enabling the OAuth proxy to know where to route authentication redirectshttps://gcsweb-private-ci.apps.ci.l2s4.p1.openshiftapps.com)These annotations follow the standard pattern used by other OAuth-protected services in the OpenShift CI infrastructure (such as release-controller and gangway). Without these annotations, the authorization server was unable to properly configure the OAuth flow for this service, resulting in "server_error" responses when attempting to authenticate requests. This change resolves that authorization issue by providing the necessary OAuth configuration metadata.