Skip to content

Skip nongroovy and upgrade e2e tests for UI-only PRs #80760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvail wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Skip nongroovy and upgrade e2e tests for UI-only PRs #80760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
568efef
Skip nongroovy and upgrade e2e tests for UI-only PRs
dvail Jun 18, 2026
ca77ba9
Remove always_run: true from jobs with skip_if_only_changed
dvail Jun 18, 2026
d104ee9
Set always_run: false explicitly to match prowgen output
dvail Jun 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ci-operator/config/stackrox/stackrox/stackrox-stackrox-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ tests:
GKE_CLUSTER_VERSION: latest
TEST_SUITE: gke-ui-e2e-tests
workflow: stackrox-stackrox-e2e-job
- always_run: true
as: gke-nongroovy-e2e-tests
- as: gke-nongroovy-e2e-tests
skip_if_only_changed: ^ui/
Comment on lines +103 to +104

@msugakov msugakov Jun 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt it's going to work as intended.

Image

These jobs are configured as required in branch rules. This means, they are required for merging PR.
If these jobs are skipped, GitHub will block PR displaying the jobs as pending.
The author of the PR will have to manually trigger them with /test <...> comments.

This would delay the PR cycle and frustrate folks who are used to have things working more automatically.

steps:
env:
COLLECTION_METHOD: core_bpf
Expand Down Expand Up @@ -152,9 +152,9 @@ tests:
GKE_CLUSTER_VERSION: latest
TEST_SUITE: gke-operator-e2e-tests
workflow: stackrox-stackrox-e2e-job
- always_run: true
as: gke-upgrade-tests
- as: gke-upgrade-tests
optional: true
skip_if_only_changed: ^ui/
steps:
workflow: stackrox-stackrox-e2e-job
- always_run: false
Expand Down
4 changes: 2 additions & 2 deletions ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4-12.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,9 @@ tests:
OCP_VERSION: ocp/stable-4.12
TEST_SUITE: ocp-compliance-e2e-tests
workflow: stackrox-automation-flavors-ocp-4-e2e
- always_run: true
as: nongroovy-e2e-tests
- as: nongroovy-e2e-tests
optional: true
skip_if_only_changed: ^ui/
steps:
env:
COLLECTION_METHOD: core_bpf
Expand Down
4 changes: 2 additions & 2 deletions ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4-21.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ tests:
OCP_VERSION: ocp/candidate-4.21
TEST_SUITE: ocp-compliance-e2e-tests
workflow: stackrox-automation-flavors-ocp-4-e2e
- always_run: true
as: nongroovy-e2e-tests
- as: nongroovy-e2e-tests
optional: true
skip_if_only_changed: ^ui/
steps:
env:
COLLECTION_METHOD: core_bpf
Expand Down
4 changes: 2 additions & 2 deletions ci-operator/config/stackrox/stackrox/stackrox-stackrox-master__ocp-4-22.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ tests:
OCP_VERSION: ocp/candidate-4.22
TEST_SUITE: ocp-compliance-e2e-tests
workflow: stackrox-automation-flavors-ocp-4-e2e
- always_run: true
as: nongroovy-e2e-tests
- as: nongroovy-e2e-tests
optional: true
skip_if_only_changed: ^ui/
steps:
env:
COLLECTION_METHOD: core_bpf
Expand Down
15 changes: 10 additions & 5 deletions ci-operator/jobs/stackrox/stackrox/stackrox-stackrox-master-presubmits.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ presubmits:
secretName: result-aggregator
trigger: (?m)^/test( | .* )gke-nongroovy-compatibility-tests,?($|\s.*)
- agent: kubernetes
always_run: true
always_run: false
branches:
- ^master$
- ^master-
Expand All @@ -744,6 +744,7 @@ presubmits:
pj-rehearse.openshift.io/can-be-rehearsed: "true"
name: pull-ci-stackrox-stackrox-master-gke-nongroovy-e2e-tests
rerun_command: /test gke-nongroovy-e2e-tests
skip_if_only_changed: ^ui/
spec:
containers:
- args:
Expand Down Expand Up @@ -1622,7 +1623,7 @@ presubmits:
secretName: result-aggregator
trigger: (?m)^/test( | .* )gke-ui-e2e-tests,?($|\s.*)
- agent: kubernetes
always_run: true
always_run: false
branches:
- ^master$
- ^master-
Expand All @@ -1637,6 +1638,7 @@ presubmits:
name: pull-ci-stackrox-stackrox-master-gke-upgrade-tests
optional: true
rerun_command: /test gke-upgrade-tests
skip_if_only_changed: ^ui/
spec:
containers:
- args:
Expand Down Expand Up @@ -2185,7 +2187,7 @@ presubmits:
secretName: result-aggregator
trigger: (?m)^/test( | .* )ocp-4-12-compliance-e2e-tests,?($|\s.*)
- agent: kubernetes
always_run: true
always_run: false
branches:
- ^master$
- ^master-
Expand All @@ -2201,6 +2203,7 @@ presubmits:
name: pull-ci-stackrox-stackrox-master-ocp-4-12-nongroovy-e2e-tests
optional: true
rerun_command: /test ocp-4-12-nongroovy-e2e-tests
skip_if_only_changed: ^ui/
spec:
containers:
- args:
Expand Down Expand Up @@ -2721,7 +2724,7 @@ presubmits:
secretName: result-aggregator
trigger: (?m)^/test( | .* )ocp-4-21-fips-qa-e2e-tests,?($|\s.*)
- agent: kubernetes
always_run: true
always_run: false
branches:
- ^master$
- ^master-
Expand All @@ -2737,6 +2740,7 @@ presubmits:
name: pull-ci-stackrox-stackrox-master-ocp-4-21-nongroovy-e2e-tests
optional: true
rerun_command: /test ocp-4-21-nongroovy-e2e-tests
skip_if_only_changed: ^ui/
spec:
containers:
- args:
Expand Down Expand Up @@ -3335,7 +3339,7 @@ presubmits:
secretName: result-aggregator
trigger: (?m)^/test( | .* )ocp-4-22-fips-qa-e2e-tests,?($|\s.*)
- agent: kubernetes
always_run: true
always_run: false
branches:
- ^master$
- ^master-
Expand All @@ -3351,6 +3355,7 @@ presubmits:
name: pull-ci-stackrox-stackrox-master-ocp-4-22-nongroovy-e2e-tests
optional: true
rerun_command: /test ocp-4-22-nongroovy-e2e-tests
skip_if_only_changed: ^ui/
spec:
containers:
- args:
Expand Down