ROX-35059: pass shared master and worker service accounts#80767
ROX-35059: pass shared master and worker service accounts#80767stehessel wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
Skipping CI for Draft Pull Request. |
|
@stehessel: This pull request references ROX-35059 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
WalkthroughTwo CI workflow YAML files for StackRox OCP 4 end-to-end tests each receive two new environment variable entries— ChangesOCP 4 Workflow Node Service Account Env Vars
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stehessel The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 164 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
2 participants
See https://github.com/stackrox/automation-flavors/pull/347 for context.
Summary by CodeRabbit
This PR modifies the OpenShift CI workflow configuration for the StackRox automation-flavors E2E testing pipelines, specifically adding support for shared master and worker service accounts.
Changes made:
Two workflow YAML files in the StackRox automation-flavors CI configuration have been updated to introduce two new environment variables:
MASTER_NODE_SERVICE_ACCOUNT: Points to the master node service accountWORKER_NODE_SERVICE_ACCOUNT: Points to the worker node service accountThese variables are added to:
ocp-4-crun-e2eworkflow (crun runtime variant) - as defaults in theocp-4-createstepocp-4-e2eworkflow (standard variant) - as environment variables in thepre.envconfigurationPractical impact:
These configuration changes allow the E2E test workflows to use dedicated service accounts for master and worker nodes, enabling more flexible and controlled test execution across different cluster node types. This supports the shared service account pattern referenced in the related automation-flavors repository changes.