[TEST ONLY] Test CNTRLPLANE-3568 AWS additional-tags propagation#80773
[TEST ONLY] Test CNTRLPLANE-3568 AWS additional-tags propagation#80773mgencur wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughA new ci-operator YAML configuration file is added for the ChangesCI and E2E Test Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
approved
mgencur
force-pushed
the
test_CNTRLPLANE-3568_user_define_tags
branch
from
84ae202 to
4426b0a
Compare
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/mgencur/hypershift/mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml`:
- Around line 54-56: The branch name in the zz_generated_metadata section is
missing the "test_" prefix and does not match the actual PR source branch.
Update the branch field value from "CNTRLPLANE-3568_user_define_tags" to
"test_CNTRLPLANE-3568_user_define_tags" in the zz_generated_metadata block,
rename the YAML file from
"mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml" to
"mgencur-hypershift-test_CNTRLPLANE-3568_user_define_tags.yaml" to match the
branch name, then re-run "make update" to regenerate the zz_generated_metadata
and related Prow job configuration files with the corrected branch name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 5fa8bdbe-86a4-4ee4-bed0-15c068163289
⛔ Files ignored due to path filters (1)
ci-operator/jobs/mgencur/hypershift/mgencur-hypershift-CNTRLPLANE-3568_user_define_tags-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/mgencur/hypershift/mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml
| branch: CNTRLPLANE-3568_user_define_tags | ||
| org: mgencur | ||
| repo: hypershift |
There was a problem hiding this comment.
Branch name in metadata does not match PR source branch.
The zz_generated_metadata.branch field and filename use CNTRLPLANE-3568_user_define_tags, but the PR source branch is test_CNTRLPLANE-3568_user_define_tags (per PR objectives). This mismatch will affect generated Prow job names and platform balancing scripts that depend on accurate branch metadata.
Correct the branch name in both the filename and zz_generated_metadata to match the actual Git branch:
- Rename file to:
mgencur-hypershift-test_CNTRLPLANE-3568_user_define_tags.yaml - Update
zz_generated_metadata.branchto:test_CNTRLPLANE-3568_user_define_tags
Then re-run make update to regenerate zz_generated_metadata and corresponding Prow job YAML files.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/mgencur/hypershift/mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml`
around lines 54 - 56, The branch name in the zz_generated_metadata section is
missing the "test_" prefix and does not match the actual PR source branch.
Update the branch field value from "CNTRLPLANE-3568_user_define_tags" to
"test_CNTRLPLANE-3568_user_define_tags" in the zz_generated_metadata block,
rename the YAML file from
"mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml" to
"mgencur-hypershift-test_CNTRLPLANE-3568_user_define_tags.yaml" to match the
branch name, then re-run "make update" to regenerate the zz_generated_metadata
and related Prow job configuration files with the corrected branch name.
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-mgencur-hypershift-CNTRLPLANE-3568_user_define_tags-e2e-v2-aws |
|
@mgencur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
Added a comment on the PR: openshift/hypershift#8712 (comment) |
|
@mgencur: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
1 participant
This is to run the new test in openshift/hypershift#8712
Summary by CodeRabbit
This PR is a test-only CI update to validate CNTRLPLANE-3568: propagation of user-defined “additional-tags” in AWS for the hypershift operator.
What changed in CI/infrastructure
ci-operator/config/.../mgencur-hypershift-CNTRLPLANE-3568_user_define_tags.yaml) to define a complete build + test pipeline for OCP 5.0:e2e-v2-awstest step that runs the AWS E2E workflow with the necessary environment overrides for the additional-tags scenario.ci-operator/step-registry/.../hypershift-e2e-v2-chain.yaml) by changing the Ginkgo label selector from excludinglifecycletests (!lifecycle) to running onlylifecycletests for hosted-cluster-aws (lifecycle && hosted-cluster-aws).Overall, the change focuses CI execution on the AWS “user-defined tags” coverage and ensures the relevant lifecycle test subset runs for AWS hosted clusters.