Skip to content

just a meaningless change#80776

Draft
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:remove_node_ztp
Draft

just a meaningless change#80776
andrej1991 wants to merge 1 commit into
openshift:mainfrom
andrej1991:remove_node_ztp

Conversation

@andrej1991

@andrej1991 andrej1991 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR adjusts the periodic testing schedule for the assisted-service repository's OpenShift CI infrastructure.

Changes: The e2e-ai-operator-ztp-remove-node-periodic job's cron schedule has been updated to run on Saturday instead of Friday. Specifically, the day-of-week field in the cron expression changed from 5 (Friday) to 6 (Saturday), while keeping the same time of 22:00 UTC.

Practical impact: This end-to-end test, which validates the node removal workflow in Zero Touch Provisioning (ZTP) deployments using the assisted-installer operator, will now execute on Saturdays instead of Fridays. The test exercises a scenario where nodes are removed from an already-deployed spoke cluster with 3 control plane agents, 2 worker agents, and 5 additional workers.

Context: The job runs on the packet-assisted cluster profile and uses the assisted-service repository's CI configuration. This appears to be a minor scheduling adjustment, possibly to balance test execution load or align with team availability on different days.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 19, 2026
@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andrej1991
Once this PR has been reviewed and has the lgtm label, please assign tsorya for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andrej1991

Copy link
Copy Markdown
Contributor Author

/pj-rehearse help

@coderabbitai

coderabbitai Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6bf5b811-6eb7-43b5-8a39-f04f738fae27

📥 Commits

Reviewing files that changed from the base of the PR and between 87a1639 and 07ac31a.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15.yaml

Walkthrough

The cron schedule for the e2e-ai-operator-ztp-remove-node-periodic job in openshift-assisted-service-release-ocm-2.15.yaml is updated by changing the day-of-week field from 5 (Friday) to 6 (Saturday).

Changes

Cron Schedule Update

Layer / File(s) Summary
Update day-of-week in cron schedule
ci-operator/config/openshift/assisted-service/openshift-assisted-service-release-ocm-2.15.yaml
The e2e-ai-operator-ztp-remove-node-periodic job's cron expression day-of-week field is changed from 5 to 6, shifting the scheduled run from Friday to Saturday.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • openshift/release#80530: Extends the job gating script to accept dow == 6 (Saturday) as a valid run day, directly complementing this PR's cron day-of-week change from 5 to 6.
🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'just a meaningless change' is vague and does not convey the specific nature of the modification, which updates a cron schedule for a CI job. Use a descriptive title that clearly indicates the purpose of the change, such as 'Update e2e-ai-operator-ztp-remove-node-periodic cron schedule day'.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR modifies only a CI configuration YAML file (cron schedule change), not Ginkgo test files. The custom check for stable test names is not applicable to this PR since there are no test name dec...
Test Structure And Quality ✅ Passed PR contains only CI configuration YAML changes (cron schedule update), not Ginkgo test code; custom check for test quality is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. The changes consist of configuration files, documentation, and utility tools that don't use Ginkgo test patterns.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added in this PR. The change is only a cron schedule modification in a CI configuration file, not test code.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only a CI configuration file's cron schedule, not deployment manifests, operator code, or workload scheduling constraints. The topology-aware scheduling check is not applicable.
Ote Binary Stdout Contract ✅ Passed PR only modifies YAML CI configuration file (cron schedule), not executable code, so no OTE Binary Stdout Contract violation is possible.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR only modifies cron schedules in YAML config files (no new Ginkgo e2e tests added). The check is not applicable as it targets new test code additions.
No-Weak-Crypto ✅ Passed PR modifies only a CI configuration file's cron schedule field. No cryptographic code, weak algorithms, custom crypto, or secret comparisons are present.
Container-Privileges ✅ Passed PR modifies only cron scheduling in CI config file, not container/K8s manifest security contexts; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation settings prese...
No-Sensitive-Data-In-Logs ✅ Passed The PR only modifies a cron schedule in a CI config YAML file. No logging is added, modified, or changed that could expose sensitive data like passwords, tokens, API keys, or PII.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andrej1991: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@andrej1991: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-assisted-service-release-ocm-2.15-e2e-ai-operator-ztp-remove-node-periodic N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andrej1991: job(s): help either don't exist or were not found to be affected, and cannot be rehearsed

@andrej1991

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-assisted-service-release-ocm-2.15-e2e-ai-operator-ztp-remove-node-periodic

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@andrej1991: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

@andrej1991: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-assisted-service-release-ocm-2.15-e2e-ai-operator-ztp-remove-node-periodic 07ac31a link unknown /pj-rehearse periodic-ci-openshift-assisted-service-release-ocm-2.15-e2e-ai-operator-ztp-remove-node-periodic

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant