Skip to content

trusted-execution-clusters: Remove operator test#81152

Open
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:no-tec-operator
Open

trusted-execution-clusters: Remove operator test#81152
Jakob-Naucke wants to merge 1 commit into
openshift:mainfrom
Jakob-Naucke:no-tec-operator

Conversation

@Jakob-Naucke

@Jakob-Naucke Jakob-Naucke commented Jun 26, 2026

Copy link
Copy Markdown
Member

Test relied on moving PR code to another host and running KinD there, which has been superseded by running on GHA
trusted-execution-clusters/operator#287.

Keeping basic structure for trusted-execution-clusters because we still intend to utilize OpenShift on #79393.

Summary by CodeRabbit

This PR updates OpenShift CI configuration under ci-operator/config/trusted-execution-clusters and ci-operator/step-registry/trusted-execution-clusters by removing the legacy operator test workflow that provisioned a Kind cluster on a Beaker host and executed the operator integration tests there (including the associated step-registry YAMLs, command scripts, metadata, and cleanup/provision chain definitions).

Practically, the operator integration test is no longer driven through the trusted-execution-clusters CI/operator Beaker → Kind → test flow, and the remaining trusted-execution-clusters scaffolding is kept for future OpenShift usage. The change also narrows CODEOWNERS routing by updating multiple OWNERS files to remove fangge1212 and yalzhang while keeping alicefr and Jakob-Naucke (as applicable per file).

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 97cb365e-94b3-4b7a-83f4-fe84c944c96e

📥 Commits

Reviewing files that changed from the base of the PR and between e1ae924 and 0975dd9.

📒 Files selected for processing (3)
  • ci-operator/config/trusted-execution-clusters/OWNERS
  • ci-operator/config/trusted-execution-clusters/operator/OWNERS
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml
💤 Files with no reviewable changes (3)
  • ci-operator/config/trusted-execution-clusters/operator/trusted-execution-clusters-operator-main.yaml
  • ci-operator/config/trusted-execution-clusters/operator/OWNERS
  • ci-operator/config/trusted-execution-clusters/OWNERS

Walkthrough

Updates trusted-execution-clusters OWNERS files across config and step-registry paths, removing named users from reviewer and approver lists.

Changes

Trusted Execution Clusters OWNERS updates

Layer / File(s) Summary
OWNERS list updates
ci-operator/config/trusted-execution-clusters/OWNERS, ci-operator/config/trusted-execution-clusters/operator/OWNERS, ci-operator/step-registry/trusted-execution-clusters/OWNERS, ci-operator/step-registry/trusted-execution-clusters/ref/OWNERS
Reviewer and approver entries were updated across the trusted-execution-clusters OWNERS files, removing named users and leaving the remaining ownership entries per file.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing the trusted-execution-clusters operator test and related CI steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only removes OWNERS and step-registry YAML/shell files; no It/Describe/Context/When test titles were added or modified.
Test Structure And Quality ✅ Passed No Ginkgo test code was changed; the PR only removes OWNERS/YAML/bash metadata under trusted-execution-clusters, so the test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the trusted-execution-clusters subtree only has OWNERS files and ast-grep found no test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; the trusted-execution-clusters subtree only contains OWNERS files, and the PR is removal-only.
Topology-Aware Scheduling Compatibility ✅ Passed PASS: the PR only changes OWNERS files in trusted-execution-clusters; no deployment manifests, operator code, or controllers were modified, so no scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed PR only removes OWNERS/YAML/shell registry assets; no Go/OTE binary process code or stdout writes are changed, so the stdout contract isn’t implicated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No new Ginkgo tests were added; the PR only removes operator/test registry files and OWNERS entries, so there are no new IPv4 or external-connectivity assumptions to flag.
No-Weak-Crypto ✅ Passed Touched trusted-execution-clusters files are deletions/empties; subtree scan found no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or custom crypto/comparison code.
Container-Privileges ✅ Passed Touched trusted-execution-clusters paths now contain only OWNERS files; no YAML/manifests or privilege settings (privileged, hostPID, hostNetwork, SYS_ADMIN, allowPrivilegeEscalation) remain.
No-Sensitive-Data-In-Logs ✅ Passed Diff only removes operator/test scripts and OWNERS files; scan found no added logging lines or sensitive tokens.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from alicefr and psalajova June 26, 2026 14:48
@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jakob-Naucke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 26, 2026
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@Jakob-Naucke

Copy link
Copy Markdown
Member Author

required diff by ci/prow/generated-config is also on main, let's wait a bit and rebase

Test relied on moving PR code to another host and running KinD there,
which has been superseded by running on GHA
trusted-execution-clusters/operator#287.

Keeping basic structure for trusted-execution-clusters because we
still intend to utilize OpenShift on openshift#79393.

Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
@openshift-ci

openshift-ci Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

@Jakob-Naucke: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Jakob-Naucke: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant