CNF-25667: Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22 - #83849
CNF-25667: Make e2e-aws-ci-tests optional for cnf-features-deploy 4.12–4.22#83849tavital wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (11)
📒 Files selected for processing (11)
🚧 Files skipped from review as they are similar to previous changes (11)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughThe CI operator configurations for CNF features deploy releases 4.12 through 4.22 now mark ChangesCNF features deploy CI configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This change makes the e2e-aws-ci-tests job non-blocking for cnf-features-deploy 4.12–4.22 while keeping execution and status reporting unchanged; no actionable merge-blocking risk remains. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@tavital: This pull request references CNF-25667 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
Mark the e2e-aws-ci-tests prow job optional so a failure no longer blocks PR merge. The job still runs (and can be retriggered with /test or /retest) and reports status, but Tide ignores it when deciding whether to merge. Set optional: true on the e2e-aws-ci-tests test in the ci-operator/config/ files for release branches 4.12 through 4.22, then ran make jobs to regenerate the corresponding Prow job configurations. Signed-off-by: Tomer Avital <tavital@redhat.com>
6c70d64 to
fb9455b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tavital The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/jira refresh |
|
@tavital: This pull request references CNF-25667 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@tavital: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mark the e2e-aws-ci-tests prow job optional so a failure no longer blocks PR merge.
The job still runs (and can be retriggered with /test or /retest) and reports status, but Tide ignores it when deciding whether to merge.
Summary by CodeRabbit
The PR updates
cnf-features-deployCI configurations for releases 4.12 through 4.22. It marks thee2e-aws-ci-testsProw job as optional.The job will continue to run and report its status. Its failures will not block PR merges.