Skip to content

Azure/ARO-HCP: collapse INT integration e2e westus3 into a single region-parameterized job - #83852

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:collapse-aro-hcp-int-westus3
Open

Azure/ARO-HCP: collapse INT integration e2e westus3 into a single region-parameterized job#83852
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:collapse-aro-hcp-int-westus3

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

What

Collapse the ARO HCP INT integration e2e jobs to a single region job, matching the production pattern.

  • Remove the integration-e2e-parallel-westus3 test from the e2e variant (postsubmit) and from the periodic variant.
  • Keep the single integration-e2e-parallel (LOCATION: uksouth default). Other regions are driven on-demand via the prow-job-executor --region flag (injected as the Gangway location-override env var), exactly like prod-e2e-parallel.

Why

The two INT integration jobs were byte-for-byte identical except for the region. Production does not maintain per-region e2e duplicates — it runs a single job and overrides the region at trigger time. This aligns INT with that approach and removes the redundant westus3 duplicate (whose periodic was parked at 0 0 1 1 *).

Generated changes

Config edits regenerated with make ci-operator-config + make jobs. Net effect on generated Prow jobs:

  • Removes branch-ci-Azure-ARO-HCP-main-e2e-integration-e2e-parallel-westus3
  • Removes periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel-westus3
  • Leaves branch-ci-Azure-ARO-HCP-main-e2e-integration-e2e-parallel and periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel (uksouth) intact

Files changed (4):

ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__e2e.yaml
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-postsubmits.yaml
ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yaml

Note for callers

Any Azure/ARO-tools invocation that targeted the -westus3 job should now call branch-ci-Azure-ARO-HCP-main-e2e-integration-e2e-parallel with --region westus3.


AI-generated. Review for accuracy.

@geoberle requested in Slack thread

Summary by CodeRabbit

  • Consolidates Azure/ARO-HCP INT integration E2E coverage into one region-parameterized integration-e2e-parallel job.
  • Removes the dedicated westus3 postsubmit and periodic jobs while preserving the default uksouth jobs.
  • Selects other regions on demand with prow-job-executor --region, including westus3 through the Gangway location override.
  • Regenerates the affected CI configuration and Prow job definitions.

Remove the per-region `integration-e2e-parallel-westus3` test from both
the ARO-HCP main e2e (postsubmit) and periodic ci-operator configs so the
INT integration e2e is a single job, matching the production job structure.
The westus3 region is driven on-demand via the --region /
MULTISTAGE_PARAM_OVERRIDE_LOCATION Gangway override rather than a duplicate
per-region job. The uksouth `integration-e2e-parallel` test is unchanged.

Generated Prow jobs were regenerated with the canonical containerized flow
(`make ci-operator-config` && `make jobs`), which removes:
  - branch-ci-Azure-ARO-HCP-main-e2e-integration-e2e-parallel-westus3
  - periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel-westus3

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@openshift-ci
openshift-ci Bot requested review from bennerv and roivaz August 22, 2026 22:49
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 12682635-5a1f-40a4-8446-ddd0c4843735

📥 Commits

Reviewing files that changed from the base of the PR and between 3fdab29 and 5082371.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__e2e.yaml
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
💤 Files with no reviewable changes (2)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__e2e.yaml
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


Walkthrough

The Azure ARO HCP CI configurations no longer define the westus3 parallel integration E2E job. Existing integration, staging, and production parallel E2E jobs remain. The periodic integration job continues to target uksouth.

Changes

Azure ARO HCP E2E configuration

Layer / File(s) Summary
Remove westus3 parallel jobs
ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__e2e.yaml, ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
The postsubmit and periodic configurations remove the integration-e2e-parallel-westus3 job definitions and their westus3-specific settings.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 50823

This change removes a redundant westus3 integration job while retaining the region-parameterized job; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the removal of the westus3 integration job and its replacement with a single region-parameterized job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only deletes westus3 CI configuration and generated Prow jobs; the diff adds no Ginkgo title APIs or dynamic test titles.
Test Structure And Quality ✅ Passed The PR changes only four generated YAML configuration files and removes jobs; it introduces no Ginkgo It blocks, resource setup, waits, or assertions to assess.
Microshift Test Compatibility ✅ Passed The diff changes only four YAML configuration/generated-job files, all by deletion; it adds no Go files or Ginkgo test declarations, so the check is inapplicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only four CI YAML files and deletes redundant job definitions; it adds no Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only deletes westus3 entries from four ci-operator config/job YAML files; it adds no deployment manifest, operator/controller code, or topology scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes only four CI YAML files, with 0 added lines; it changes no OTE or binary source and introduces no process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff contains only four YAML job-configuration deletions and no new Ginkgo tests or networking code, so this compatibility check is inapplicable.
No-Weak-Crypto ✅ Passed The commit changes only four YAML config/job files and adds no lines; the patch introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or comparison logic.
Container-Privileges ✅ Passed The PR only deletes redundant westus3 config and generated jobs; it adds no privileged, host namespace, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR has 0 added lines and only removes two westus3 job definitions; retained jobs and log-report templates are unchanged, so no new sensitive-data logging is introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign geoberle for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 22, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@redhat-chai-bot: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@openshift-ci

openshift-ci Bot commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant