Skip to content

setup assisted-installer version v2.55 - #83856

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-8670635e-1d33-43fa-85fb-cc1bb3871c2d
Open

setup assisted-installer version v2.55#83856
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-8670635e-1d33-43fa-85fb-cc1bb3871c2d

Conversation

@danmanor

@danmanor danmanor commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updates the Assisted Installer v2.55 CI configurations.
  • Sets always_run: false for the subsystem-test and e2e-metal-assisted tests.
  • Uses pipeline_skip_if_only_changed for path-based test skipping.
  • Applies these changes to both the Assisted Installer Agent and Assisted Installer repositories.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 041b1f55-d95f-4b5b-8ea9-0a956790d803

📥 Commits

Reviewing files that changed from the base of the PR and between 73d8eaa and fa33ff7.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The pull request updates Assisted Installer CI test configurations. Affected tests disable unconditional execution and use pipeline_skip_if_only_changed for path-based skipping.

Changes

CI skip configuration

Layer / File(s) Summary
Update test execution and path skipping
ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The affected subsystem-test and e2e-metal-assisted definitions set always_run: false and replace skip_if_only_changed with pipeline_skip_if_only_changed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to fa33f

This localized CI version update has no actionable merge-blocking risk; it is merge-ready after the normal configuration generation and validation checks.

Possibly related PRs

Suggested labels: approved

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the assisted-installer v2.55 setup change covered by the pull request.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The diff changes only CI YAML skip annotations and job settings; it adds no Ginkgo title APIs or dynamic test-title values.
Test Structure And Quality ✅ Passed The commit changes only four YAML CI configuration files; the diff contains no Ginkgo test code, so the listed test-quality requirements are inapplicable.
Microshift Test Compatibility ✅ Passed The commit changes only CI YAML scheduling metadata and generated presubmit jobs; it adds no Ginkgo tests or MicroShift-incompatible API references.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only four YAML CI configuration files; the diff adds no Ginkgo It, Describe, Context, or When declarations and does not add e2e test code.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only ci-operator test and generated Prow job YAML. It adds always_run and pipeline skip annotations; no workload scheduling constraints are introduced.
Ote Binary Stdout Contract ✅ Passed The PR changes only CI and generated Prow YAML; no OTE binary source or process-level stdout writes changed, and the diff contains no logging or stdout-related terms.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only four YAML CI scheduling files. It adds no Ginkgo tests, IPv4 values, URLs, registry pulls, or external connectivity code.
No-Weak-Crypto ✅ Passed The HEAD diff changes only CI scheduling and generated annotations; the added-line scan found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, crypto, or timing-comparison usage.
Container-Privileges ✅ Passed The commit only changes test scheduling fields; added and complete manifest lines contain no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true.
No-Sensitive-Data-In-Logs ✅ Passed The commit changes only CI skip metadata and generated job annotations; it adds no logging, secrets, tokens, credentials, PII, hostnames, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants