openshift/metallb: add dualstack periodic ci - #84346
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. WalkthroughA periodic dual-stack MetalLB e2e job is added for the release-5.0 branch. The e2e script now copies artifacts for every test result and preserves the original test exit code. ChangesMetalLB CI
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR adds a dual-stack periodic MetalLB CI job and adjusts the associated test command; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation The pull request does not add or modify any Ginkgo test declaration. The changed shell script only runs Full details: Test Structure And QualityExplanation PASS: The pull request does not add or modify Ginkgo test code. The diff contains two YAML CI configuration files and one shell test-command wrapper. The shell change only captures the E2E exit code, copies artifacts, restores Full details: Microshift Test CompatibilityExplanation The check is not applicable. The diff against origin/main adds CI configuration and a generated job, and changes artifact/exit-code handling in an existing shell command. It adds no Ginkgo test definitions or test bodies: no new Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request adds CI configuration and changes artifact handling in a shell harness. The complete diff contains no new Go or Ginkgo test declarations such as It(), Describe(), Context(), or When(). Therefore, the SNO compatibility check is not applicable. Full details: Topology-Aware Scheduling CompatibilityExplanation PASS — The PR changes only CI configuration, a generated Prow job, and E2E result handling. The added files contain no anti-affinity, topology spread, node selector/affinity, tolerations, replica, PDB, or arbiter scheduling settings. The modified shell script only captures the test exit code and copies artifacts. The activated workflow also contains no topology-sensitive scheduling constraints. Full details: Ote Binary Stdout ContractExplanation The check is not applicable to the changed code. The PR adds CI YAML and a shell command step. It adds no Go source, OTE binary, suite setup, or process-level logging code. The shell changes only capture the remote Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS — The custom check is not applicable. The pull request adds two YAML CI configuration files and changes one shell command script. The exact diff adds no Ginkgo tests or test source, and no added Full details: No-Weak-CryptoExplanation PASS: The pull request adds CI YAML and changes E2E artifact handling only. The complete diff adds no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret/token comparisons. The only comparison is the numeric E2E exit code. Full details: Container-PrivilegesExplanation No explicit container-privilege violation was introduced. The added CI configuration contains no Full details: No-Sensitive-Data-In-LogsExplanation PASS: The PR adds only CI metadata and changes artifact collection. The new YAML contains a Slack channel, cluster profile, workflow, and network settings, but no passwords, tokens, API keys, PII, or customer data. The shell change copies ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9e2eea9 to
1456f7b
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/pj-rehearse |
|
/pj-rehearse periodic-ci-openshift-metallb-release-5.0-dualstack-periodics-metallb-e2e-metal-dualstack-periodic |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
1 similar comment
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ajaggapa The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ec6c533 to
327b9a2
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
/retest-required |
|
/retest-failed |
|
/retest |
|
/retest-failed |
|
/retest |
Signed-off-by: Anvesh Jaggapatruni <ajaggapa@redhat.com>
Signed-off-by: Anvesh Jaggapatruni <ajaggapa@redhat.com>
327b9a2 to
71aeb82
Compare
|
[REHEARSALNOTIFIER]
A total of 95 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
| ssh "${SSHOPTS[@]}" "root@${IP}" "cd /root/dev-scripts/metallb/openshift-ci/ && ${vars} ./run_e2e.sh" | ||
| if [ $? -ne 0 ]; then | ||
| scp "${SSHOPTS[@]}" -r "root@${IP}:/logs/artifacts" "${ARTIFACT_DIR}" | ||
| TEST_EXIT_CODE=$? |
There was a problem hiding this comment.
why we might want this (I mean, the whole commit)?
There was a problem hiding this comment.
After openshift/metallb#300, we are placing the fetching the junit file for the Spyglass Lens to pick it to display the tests passed/failed/skipped in the main page of the job.
Without this commit, it is displaying (pass/fail/skip) only when atleast 1 test fails. It would be good to have the tests displayed directly irrespective of the test result.
for example, this job shows the tests failed in the main page compared to this job without fetching junit file
There was a problem hiding this comment.
presubmit job shows success, but to know the tests it ran, we need to go through artifacts buildlog
|
/pj-rehearse pull-ci-openshift-metallb-main-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-metallb-main-metallb-e2e-metal |
|
@ajaggapa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@ajaggapa: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Adds a release-5.0 dual-stack periodic CI job for openshift/metallb to run MetalLB e2e on bare metal with IPv4/IPv6 (v4v6).
Summary by CodeRabbit
openshift/metallb.equinix-ocp-metalcluster profile andbaremetalds-metallb-e2eworkflow.frr-k8s-cnoBGP.#team-metallb-ci-periodic.