Fix AI instruction quality and bump apm-cli to 0.13.0

[not-stbenjam]

Summary

• Removes hedging language ("ideally", "where possible") in .coderabbit.yaml in favor of direct requirements
• Moves critical instructions out of the middle of long prompt files to the top or bottom where LLMs pay more attention
• Bumps apm-cli from 0.11.0 to 0.13.0 and updates apm.yml to the current config format
• Recompiles all generated APM output

Issues found by skillsaw, a linter for AI config files.

Test plan

• skillsaw . passes with 0 errors and 0 warnings
• make verify-apm passes
• No code changes, only instruction text and APM tooling

🤖 Generated with Claude Code

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

[coderabbitai]

Walkthrough

Four APM prompt files and CodeRabbit config wording are updated; Makefile apm CLI version, apm.yml formatting/dependencies, apm.lock refresh, and generated MCP metadata headers are also changed.

Changes

Prompt and Configuration Clarifications

Layer / File(s)	Summary
Release View Generation Guidance .apm/prompts/sippy-generate-release-views.prompt.md	Adds explicit guidance to replace ga with now for relative_start/relative_end when the base release becomes the sample release, applied in multiple workflow sections.
Release View Update Guidance .apm/prompts/sippy-update-ga-release-views.prompt.md	Moves the YAML formatting preservation instruction from an earlier workflow position to a later "Important Notes" section without other changes.
Job Variant Update Guidance .apm/prompts/sippy-update-job-variant.prompt.md	Rewords and relocates pattern-ordering guidance: adds precedence reminder to the code-modify step and moves the full "Pattern Ordering is CRITICAL" subsection into Helper Commands, preserving early-return/first-match examples.
Code Review Configuration .coderabbit.yaml	Tightens review rules: pkg/**/query/** must stay under 200 lines, and new/modified features must include test coverage.
Makefile apm target Makefile	Bumps the apm target to use apm-cli@0.12.4 for apm install and apm compile.
APM lockfile updates apm.lock.yaml	Refreshes local_deployed_files and local_deployed_file_hashes, removing restore-prodlike variants and docs entries and updating hashes for multiple agent command/rule files.
APM manifest formatting apm.yml	Convert targets to a multiline list and replace dependencies: {} with explicit apm: [] and mcp: [].
Regenerated MCP metadata mcp/AGENTS.md, mcp/CLAUDE.md	Update generated file headers with new Build ID and APM CLI version (v0.12.4).

Estimated Code Review Effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title claims 'bump apm-cli to 0.13.0' but the actual changes show an upgrade to 0.12.4, not 0.13.0. This is a factual inaccuracy.	Correct the title to reflect the actual version change: 'Fix AI instruction quality and bump apm-cli to 0.12.4'.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hi @not-stbenjam. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.apm/prompts/sippy-generate-release-views.prompt.md:
- Around line 8-10: Unify the wording so the replacement scope is precise:
change both occurrences that currently say "replace 'ga' with 'now' in relative
dates" or mix fields to instead instruct only the exact fields relative_start
and relative_end to be updated when base becomes source release; update the two
lines shown and the other occurrence referenced (lines 62-63) so every
instruction consistently reads something like "When base becomes source release,
replace 'ga' with 'now' in relative_start and relative_end" to avoid
broad/ambiguous edits.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b874d9a1-dc8a-4bb6-b94e-8163f5c46245

📥 Commits

Reviewing files that changed from the base of the PR and between e682208 and 514f91f.

📒 Files selected for processing (4)

• .apm/prompts/sippy-generate-release-views.prompt.md
• .apm/prompts/sippy-update-ga-release-views.prompt.md
• .apm/prompts/sippy-update-job-variant.prompt.md
• .coderabbit.yaml

[stbenjam]

/ok-to-test

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[openshift-merge-bot]

Scheduling required tests:
/test e2e

[petr-muller]

These two seem very strict, but I guess we can tune if CR becomes too zealous

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: not-stbenjam, petr-muller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [petr-muller]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@not-stbenjam: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.